Commit ce5df776 authored by Johannes Weiner's avatar Johannes Weiner Committed by Andrew Morton

mm: page_isolation: write proper kerneldoc

And remove the incorrect header comments.

[akpm@linux-foundation.org: s/lower/first/, s/upper/last/, per Mike]
Link: https://lkml.kernel.org/r/20230519111652.40658-1-hannes@cmpxchg.orgSigned-off-by: default avatarJohannes Weiner <hannes@cmpxchg.org>
Cc: Mike Rapoport <rppt@kernel.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent a6e79df9
...@@ -37,24 +37,12 @@ void set_pageblock_migratetype(struct page *page, int migratetype); ...@@ -37,24 +37,12 @@ void set_pageblock_migratetype(struct page *page, int migratetype);
int move_freepages_block(struct zone *zone, struct page *page, int move_freepages_block(struct zone *zone, struct page *page,
int migratetype, int *num_movable); int migratetype, int *num_movable);
/* int start_isolate_page_range(unsigned long start_pfn, unsigned long end_pfn,
* Changes migrate type in [start_pfn, end_pfn) to be MIGRATE_ISOLATE.
*/
int
start_isolate_page_range(unsigned long start_pfn, unsigned long end_pfn,
int migratetype, int flags, gfp_t gfp_flags); int migratetype, int flags, gfp_t gfp_flags);
/* void undo_isolate_page_range(unsigned long start_pfn, unsigned long end_pfn,
* Changes MIGRATE_ISOLATE to MIGRATE_MOVABLE.
* target range is [start_pfn, end_pfn)
*/
void
undo_isolate_page_range(unsigned long start_pfn, unsigned long end_pfn,
int migratetype); int migratetype);
/*
* Test all pages in [start_pfn, end_pfn) are isolated or not.
*/
int test_pages_isolated(unsigned long start_pfn, unsigned long end_pfn, int test_pages_isolated(unsigned long start_pfn, unsigned long end_pfn,
int isol_flags); int isol_flags);
......
...@@ -481,10 +481,9 @@ static int isolate_single_pageblock(unsigned long boundary_pfn, int flags, ...@@ -481,10 +481,9 @@ static int isolate_single_pageblock(unsigned long boundary_pfn, int flags,
} }
/** /**
* start_isolate_page_range() - make page-allocation-type of range of pages to * start_isolate_page_range() - mark page range MIGRATE_ISOLATE
* be MIGRATE_ISOLATE. * @start_pfn: The first PFN of the range to be isolated.
* @start_pfn: The lower PFN of the range to be isolated. * @end_pfn: The last PFN of the range to be isolated.
* @end_pfn: The upper PFN of the range to be isolated.
* @migratetype: Migrate type to set in error recovery. * @migratetype: Migrate type to set in error recovery.
* @flags: The following flags are allowed (they can be combined in * @flags: The following flags are allowed (they can be combined in
* a bit mask) * a bit mask)
...@@ -571,8 +570,14 @@ int start_isolate_page_range(unsigned long start_pfn, unsigned long end_pfn, ...@@ -571,8 +570,14 @@ int start_isolate_page_range(unsigned long start_pfn, unsigned long end_pfn,
return 0; return 0;
} }
/* /**
* Make isolated pages available again. * undo_isolate_page_range - undo effects of start_isolate_page_range()
* @start_pfn: The first PFN of the isolated range
* @end_pfn: The last PFN of the isolated range
* @migratetype: New migrate type to set on the range
*
* This finds every MIGRATE_ISOLATE page block in the given range
* and switches it to @migratetype.
*/ */
void undo_isolate_page_range(unsigned long start_pfn, unsigned long end_pfn, void undo_isolate_page_range(unsigned long start_pfn, unsigned long end_pfn,
int migratetype) int migratetype)
...@@ -631,7 +636,21 @@ __test_page_isolated_in_pageblock(unsigned long pfn, unsigned long end_pfn, ...@@ -631,7 +636,21 @@ __test_page_isolated_in_pageblock(unsigned long pfn, unsigned long end_pfn,
return pfn; return pfn;
} }
/* Caller should ensure that requested range is in a single zone */ /**
* test_pages_isolated - check if pageblocks in range are isolated
* @start_pfn: The first PFN of the isolated range
* @end_pfn: The first PFN *after* the isolated range
* @isol_flags: Testing mode flags
*
* This tests if all in the specified range are free.
*
* If %MEMORY_OFFLINE is specified in @flags, it will consider
* poisoned and offlined pages free as well.
*
* Caller must ensure the requested range doesn't span zones.
*
* Returns 0 if true, -EBUSY if one or more pages are in use.
*/
int test_pages_isolated(unsigned long start_pfn, unsigned long end_pfn, int test_pages_isolated(unsigned long start_pfn, unsigned long end_pfn,
int isol_flags) int isol_flags)
{ {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment