Commit ceabee6c authored by YueHaibing's avatar YueHaibing Committed by David S. Miller

genetlink: Fix a memory leak on error path

In genl_register_family(), when idr_alloc() fails,
we forget to free the memory we possibly allocate for
family->attrbuf.
Reported-by: default avatarHulk Robot <hulkci@huawei.com>
Fixes: 2ae0f17d ("genetlink: use idr to track families")
Signed-off-by: default avatarYueHaibing <yuehaibing@huawei.com>
Reviewed-by: default avatarKirill Tkhai <ktkhai@virtuozzo.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 33872d79
...@@ -366,7 +366,7 @@ int genl_register_family(struct genl_family *family) ...@@ -366,7 +366,7 @@ int genl_register_family(struct genl_family *family)
start, end + 1, GFP_KERNEL); start, end + 1, GFP_KERNEL);
if (family->id < 0) { if (family->id < 0) {
err = family->id; err = family->id;
goto errout_locked; goto errout_free;
} }
err = genl_validate_assign_mc_groups(family); err = genl_validate_assign_mc_groups(family);
...@@ -385,6 +385,7 @@ int genl_register_family(struct genl_family *family) ...@@ -385,6 +385,7 @@ int genl_register_family(struct genl_family *family)
errout_remove: errout_remove:
idr_remove(&genl_fam_idr, family->id); idr_remove(&genl_fam_idr, family->id);
errout_free:
kfree(family->attrbuf); kfree(family->attrbuf);
errout_locked: errout_locked:
genl_unlock_all(); genl_unlock_all();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment