Commit cebd6fbe authored by Rasmus Villemoes's avatar Rasmus Villemoes Committed by Vincent Abriou

drm/sti: remove redundant sign extensions

arg is long int, so arg = (arg << 22) >> 22 makes the upper 22 bits of
arg equal to bit 9 (or bit 41). But we then mask away all but bits 0-9, so
this is entirely redundant.
Signed-off-by: default avatarRasmus Villemoes <linux@rasmusvillemoes.dk>
Reviewed-by: default avatarVincent Abriou <vincent.abriou@st.com>
parent 4d5821a7
...@@ -65,7 +65,6 @@ static int awg_generate_instr(enum opcode opcode, ...@@ -65,7 +65,6 @@ static int awg_generate_instr(enum opcode opcode,
mux = 0; mux = 0;
data_enable = 0; data_enable = 0;
arg = (arg << 22) >> 22;
arg &= (0x3ff); arg &= (0x3ff);
break; break;
case REPEAT: case REPEAT:
...@@ -77,14 +76,12 @@ static int awg_generate_instr(enum opcode opcode, ...@@ -77,14 +76,12 @@ static int awg_generate_instr(enum opcode opcode,
mux = 0; mux = 0;
data_enable = 0; data_enable = 0;
arg = (arg << 22) >> 22;
arg &= (0x3ff); arg &= (0x3ff);
break; break;
case JUMP: case JUMP:
mux = 0; mux = 0;
data_enable = 0; data_enable = 0;
arg |= 0x40; /* for jump instruction 7th bit is 1 */ arg |= 0x40; /* for jump instruction 7th bit is 1 */
arg = (arg << 22) >> 22;
arg &= 0x3ff; arg &= 0x3ff;
break; break;
case STOP: case STOP:
...@@ -94,7 +91,6 @@ static int awg_generate_instr(enum opcode opcode, ...@@ -94,7 +91,6 @@ static int awg_generate_instr(enum opcode opcode,
case RPTSET: case RPTSET:
case RPLSET: case RPLSET:
case HOLD: case HOLD:
arg = (arg << 24) >> 24;
arg &= (0x0ff); arg &= (0x0ff);
break; break;
default: default:
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment