Commit d160147b authored by Wenwei Tao's avatar Wenwei Tao Committed by Jens Axboe

lightnvm: do device max sectors boundary check first

do device max_phys_sect boundary check first, otherwise
we will allocate dma_pools for devices whose max sectors
are beyond lightnvm support and register them.
Signed-off-by: default avatarWenwei Tao <ww.tao0320@gmail.com>
Signed-off-by: default avatarMatias Bjørling <m@bjorling.me>
Signed-off-by: default avatarJens Axboe <axboe@fb.com>
parent 76e25081
...@@ -308,6 +308,12 @@ int nvm_register(struct request_queue *q, char *disk_name, ...@@ -308,6 +308,12 @@ int nvm_register(struct request_queue *q, char *disk_name,
if (ret) if (ret)
goto err_init; goto err_init;
if (dev->ops->max_phys_sect > 256) {
pr_info("nvm: max sectors supported is 256.\n");
ret = -EINVAL;
goto err_init;
}
if (dev->ops->max_phys_sect > 1) { if (dev->ops->max_phys_sect > 1) {
dev->ppalist_pool = dev->ops->create_dma_pool(dev->q, dev->ppalist_pool = dev->ops->create_dma_pool(dev->q,
"ppalist"); "ppalist");
...@@ -316,10 +322,6 @@ int nvm_register(struct request_queue *q, char *disk_name, ...@@ -316,10 +322,6 @@ int nvm_register(struct request_queue *q, char *disk_name,
ret = -ENOMEM; ret = -ENOMEM;
goto err_init; goto err_init;
} }
} else if (dev->ops->max_phys_sect > 256) {
pr_info("nvm: max sectors supported is 256.\n");
ret = -EINVAL;
goto err_init;
} }
down_write(&nvm_lock); down_write(&nvm_lock);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment