Commit d1dd206c authored by Fengguang Wu's avatar Fengguang Wu Committed by Herbert Xu

crytpo: ccp - fix coccinelle warnings

drivers/crypto/ccp/ccp-crypto-aes.c:344:1-7: Replace memcpy with struct assignment
drivers/crypto/ccp/ccp-crypto-sha.c:398:1-7: Replace memcpy with struct assignment
drivers/crypto/ccp/ccp-dev.c:578:2-3: Unneeded semicolon
/c/kernel-tests/src/cocci/drivers/crypto/ccp/ccp-dev.c:565:2-3: Unneeded semicolon

Generated by: coccinelle/misc/memcpy-assign.cocci

CC: Tom Lendacky <thomas.lendacky@amd.com>
Signed-off-by: default avatarFengguang Wu <fengguang.wu@intel.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent f7b2b5dd
...@@ -341,7 +341,7 @@ static int ccp_register_aes_alg(struct list_head *head, ...@@ -341,7 +341,7 @@ static int ccp_register_aes_alg(struct list_head *head,
/* Copy the defaults and override as necessary */ /* Copy the defaults and override as necessary */
alg = &ccp_alg->alg; alg = &ccp_alg->alg;
memcpy(alg, def->alg_defaults, sizeof(*alg)); *alg = *def->alg_defaults;
snprintf(alg->cra_name, CRYPTO_MAX_ALG_NAME, "%s", def->name); snprintf(alg->cra_name, CRYPTO_MAX_ALG_NAME, "%s", def->name);
snprintf(alg->cra_driver_name, CRYPTO_MAX_ALG_NAME, "%s", snprintf(alg->cra_driver_name, CRYPTO_MAX_ALG_NAME, "%s",
def->driver_name); def->driver_name);
......
...@@ -395,7 +395,7 @@ static int ccp_register_hmac_alg(struct list_head *head, ...@@ -395,7 +395,7 @@ static int ccp_register_hmac_alg(struct list_head *head,
return -ENOMEM; return -ENOMEM;
/* Copy the base algorithm and only change what's necessary */ /* Copy the base algorithm and only change what's necessary */
memcpy(ccp_alg, base_alg, sizeof(*ccp_alg)); *ccp_alg = *base_alg;
INIT_LIST_HEAD(&ccp_alg->entry); INIT_LIST_HEAD(&ccp_alg->entry);
strncpy(ccp_alg->child_alg, def->name, CRYPTO_MAX_ALG_NAME); strncpy(ccp_alg->child_alg, def->name, CRYPTO_MAX_ALG_NAME);
......
...@@ -562,7 +562,7 @@ static int __init ccp_mod_init(void) ...@@ -562,7 +562,7 @@ static int __init ccp_mod_init(void)
return -ENODEV; return -ENODEV;
return ccp_pci_init(); return ccp_pci_init();
break; break;
}; }
return -ENODEV; return -ENODEV;
} }
...@@ -575,7 +575,7 @@ static void __exit ccp_mod_exit(void) ...@@ -575,7 +575,7 @@ static void __exit ccp_mod_exit(void)
case 22: case 22:
ccp_pci_exit(); ccp_pci_exit();
break; break;
}; }
} }
module_init(ccp_mod_init); module_init(ccp_mod_init);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment