Commit d4332013 authored by Jean Delvare's avatar Jean Delvare Committed by Greg Kroah-Hartman

driver core: dev_get_drvdata: Don't check for NULL dev

There is no point in calling dev_get_drvdata without a valid device.
So checking for dev == NULL is pointless. If such a check is ever
needed - which I doubt - the driver should do it before calling
dev_get_drvdata.

We were returning NULL if dev was NULL, which the caller certainly did
not expect anyway, so that was only delaying the crash if the caller
is not paying attention.
Signed-off-by: default avatarJean Delvare <jdelvare@suse.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 2c1f1ff0
...@@ -594,9 +594,7 @@ void driver_detach(struct device_driver *drv) ...@@ -594,9 +594,7 @@ void driver_detach(struct device_driver *drv)
*/ */
void *dev_get_drvdata(const struct device *dev) void *dev_get_drvdata(const struct device *dev)
{ {
if (dev)
return dev->driver_data; return dev->driver_data;
return NULL;
} }
EXPORT_SYMBOL(dev_get_drvdata); EXPORT_SYMBOL(dev_get_drvdata);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment