Commit d450f828 authored by Bjorn Helgaas's avatar Bjorn Helgaas

Merge branch 'pci/misc'

- Align checking of syscall user config accessor return codes (Heiner
  Kallweit)

- Fix "ordering" comment typos (Bjorn Helgaas)

- Fix 'ARM/TEXAS INSTRUMENT KEYSTONE CLOCKSOURCE' capitalization in
  MAINTAINERS (Bjorn Helgaas)

- Add Silicom Denmark vendor ID (Martin Hundebøll)

- Apply CONFIG_PCI_DEBUG to entire drivers/pci hierarchy (Junhao He)

- Remove WARN_ON(in_interrupt()) (Sebastian Andrzej Siewior)

* pci/misc:
  PCI: Remove WARN_ON(in_interrupt())
  PCI: Apply CONFIG_PCI_DEBUG to entire drivers/pci hierarchy
  PCI: Add Silicom Denmark vendor ID
  MAINTAINERS: Fix 'ARM/TEXAS INSTRUMENT KEYSTONE CLOCKSOURCE' capitalization
  Fix "ordering" comment typos
  PCI: Align checking of syscall user config accessors
parents 617e3a8b 9a147122
...@@ -2603,7 +2603,7 @@ L: linux-kernel@vger.kernel.org ...@@ -2603,7 +2603,7 @@ L: linux-kernel@vger.kernel.org
S: Maintained S: Maintained
F: drivers/clk/keystone/ F: drivers/clk/keystone/
ARM/TEXAS INSTRUMENT KEYSTONE ClOCKSOURCE ARM/TEXAS INSTRUMENT KEYSTONE CLOCKSOURCE
M: Santosh Shilimkar <ssantosh@kernel.org> M: Santosh Shilimkar <ssantosh@kernel.org>
L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers) L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
L: linux-kernel@vger.kernel.org L: linux-kernel@vger.kernel.org
......
...@@ -44,7 +44,7 @@ static inline int __test_facility(unsigned long nr, void *facilities) ...@@ -44,7 +44,7 @@ static inline int __test_facility(unsigned long nr, void *facilities)
} }
/* /*
* The test_facility function uses the bit odering where the MSB is bit 0. * The test_facility function uses the bit ordering where the MSB is bit 0.
* That makes it easier to query facility bits with the bit number as * That makes it easier to query facility bits with the bit number as
* documented in the Principles of Operation. * documented in the Principles of Operation.
*/ */
......
...@@ -141,7 +141,7 @@ static void qxl_drm_release(struct drm_device *dev) ...@@ -141,7 +141,7 @@ static void qxl_drm_release(struct drm_device *dev)
/* /*
* TODO: qxl_device_fini() call should be in qxl_pci_remove(), * TODO: qxl_device_fini() call should be in qxl_pci_remove(),
* reodering qxl_modeset_fini() + qxl_device_fini() calls is * reordering qxl_modeset_fini() + qxl_device_fini() calls is
* non-trivial though. * non-trivial though.
*/ */
qxl_modeset_fini(qdev); qxl_modeset_fini(qdev);
......
...@@ -866,7 +866,7 @@ struct iwl_fw_dbg_trigger_time_event { ...@@ -866,7 +866,7 @@ struct iwl_fw_dbg_trigger_time_event {
* tx_bar: tid bitmap to configure on what tid the trigger should occur * tx_bar: tid bitmap to configure on what tid the trigger should occur
* when a BAR is send (for an Rx BlocAck session). * when a BAR is send (for an Rx BlocAck session).
* frame_timeout: tid bitmap to configure on what tid the trigger should occur * frame_timeout: tid bitmap to configure on what tid the trigger should occur
* when a frame times out in the reodering buffer. * when a frame times out in the reordering buffer.
*/ */
struct iwl_fw_dbg_trigger_ba { struct iwl_fw_dbg_trigger_ba {
__le16 rx_ba_start; __le16 rx_ba_start;
......
...@@ -36,4 +36,4 @@ obj-$(CONFIG_PCI_ENDPOINT) += endpoint/ ...@@ -36,4 +36,4 @@ obj-$(CONFIG_PCI_ENDPOINT) += endpoint/
obj-y += controller/ obj-y += controller/
obj-y += switch/ obj-y += switch/
ccflags-$(CONFIG_PCI_DEBUG) := -DDEBUG subdir-ccflags-$(CONFIG_PCI_DEBUG) := -DDEBUG
...@@ -168,7 +168,6 @@ struct pci_bus *pci_find_next_bus(const struct pci_bus *from) ...@@ -168,7 +168,6 @@ struct pci_bus *pci_find_next_bus(const struct pci_bus *from)
struct list_head *n; struct list_head *n;
struct pci_bus *b = NULL; struct pci_bus *b = NULL;
WARN_ON(in_interrupt());
down_read(&pci_bus_sem); down_read(&pci_bus_sem);
n = from ? from->node.next : pci_root_buses.next; n = from ? from->node.next : pci_root_buses.next;
if (n != &pci_root_buses) if (n != &pci_root_buses)
...@@ -196,7 +195,6 @@ struct pci_dev *pci_get_slot(struct pci_bus *bus, unsigned int devfn) ...@@ -196,7 +195,6 @@ struct pci_dev *pci_get_slot(struct pci_bus *bus, unsigned int devfn)
{ {
struct pci_dev *dev; struct pci_dev *dev;
WARN_ON(in_interrupt());
down_read(&pci_bus_sem); down_read(&pci_bus_sem);
list_for_each_entry(dev, &bus->devices, bus_list) { list_for_each_entry(dev, &bus->devices, bus_list) {
...@@ -274,7 +272,6 @@ static struct pci_dev *pci_get_dev_by_id(const struct pci_device_id *id, ...@@ -274,7 +272,6 @@ static struct pci_dev *pci_get_dev_by_id(const struct pci_device_id *id,
struct device *dev_start = NULL; struct device *dev_start = NULL;
struct pci_dev *pdev = NULL; struct pci_dev *pdev = NULL;
WARN_ON(in_interrupt());
if (from) if (from)
dev_start = &from->dev; dev_start = &from->dev;
dev = bus_find_device(&pci_bus_type, dev_start, (void *)id, dev = bus_find_device(&pci_bus_type, dev_start, (void *)id,
...@@ -381,7 +378,6 @@ int pci_dev_present(const struct pci_device_id *ids) ...@@ -381,7 +378,6 @@ int pci_dev_present(const struct pci_device_id *ids)
{ {
struct pci_dev *found = NULL; struct pci_dev *found = NULL;
WARN_ON(in_interrupt());
while (ids->vendor || ids->subvendor || ids->class_mask) { while (ids->vendor || ids->subvendor || ids->class_mask) {
found = pci_get_dev_by_id(ids, NULL); found = pci_get_dev_by_id(ids, NULL);
if (found) { if (found) {
......
...@@ -20,7 +20,7 @@ SYSCALL_DEFINE5(pciconfig_read, unsigned long, bus, unsigned long, dfn, ...@@ -20,7 +20,7 @@ SYSCALL_DEFINE5(pciconfig_read, unsigned long, bus, unsigned long, dfn,
u16 word; u16 word;
u32 dword; u32 dword;
long err; long err;
long cfg_ret; int cfg_ret;
if (!capable(CAP_SYS_ADMIN)) if (!capable(CAP_SYS_ADMIN))
return -EPERM; return -EPERM;
...@@ -46,7 +46,7 @@ SYSCALL_DEFINE5(pciconfig_read, unsigned long, bus, unsigned long, dfn, ...@@ -46,7 +46,7 @@ SYSCALL_DEFINE5(pciconfig_read, unsigned long, bus, unsigned long, dfn,
} }
err = -EIO; err = -EIO;
if (cfg_ret != PCIBIOS_SUCCESSFUL) if (cfg_ret)
goto error; goto error;
switch (len) { switch (len) {
...@@ -105,7 +105,7 @@ SYSCALL_DEFINE5(pciconfig_write, unsigned long, bus, unsigned long, dfn, ...@@ -105,7 +105,7 @@ SYSCALL_DEFINE5(pciconfig_write, unsigned long, bus, unsigned long, dfn,
if (err) if (err)
break; break;
err = pci_user_write_config_byte(dev, off, byte); err = pci_user_write_config_byte(dev, off, byte);
if (err != PCIBIOS_SUCCESSFUL) if (err)
err = -EIO; err = -EIO;
break; break;
...@@ -114,7 +114,7 @@ SYSCALL_DEFINE5(pciconfig_write, unsigned long, bus, unsigned long, dfn, ...@@ -114,7 +114,7 @@ SYSCALL_DEFINE5(pciconfig_write, unsigned long, bus, unsigned long, dfn,
if (err) if (err)
break; break;
err = pci_user_write_config_word(dev, off, word); err = pci_user_write_config_word(dev, off, word);
if (err != PCIBIOS_SUCCESSFUL) if (err)
err = -EIO; err = -EIO;
break; break;
...@@ -123,7 +123,7 @@ SYSCALL_DEFINE5(pciconfig_write, unsigned long, bus, unsigned long, dfn, ...@@ -123,7 +123,7 @@ SYSCALL_DEFINE5(pciconfig_write, unsigned long, bus, unsigned long, dfn,
if (err) if (err)
break; break;
err = pci_user_write_config_dword(dev, off, dword); err = pci_user_write_config_dword(dev, off, dword);
if (err != PCIBIOS_SUCCESSFUL) if (err)
err = -EIO; err = -EIO;
break; break;
......
...@@ -2588,6 +2588,8 @@ ...@@ -2588,6 +2588,8 @@
#define PCI_VENDOR_ID_REDHAT 0x1b36 #define PCI_VENDOR_ID_REDHAT 0x1b36
#define PCI_VENDOR_ID_SILICOM_DENMARK 0x1c2c
#define PCI_VENDOR_ID_AMAZON_ANNAPURNA_LABS 0x1c36 #define PCI_VENDOR_ID_AMAZON_ANNAPURNA_LABS 0x1c36
#define PCI_VENDOR_ID_CIRCUITCO 0x1cc8 #define PCI_VENDOR_ID_CIRCUITCO 0x1cc8
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment