Skip to content

L
linux
Commit d6905f08 authored by Florian Westphal's avatar Florian Westphal Committed by Jakub Kicinski
Browse files
Options

selftests: netfilter: nft_nat_zones.sh: shellcheck cleanups 

While at it: No need for iperf here, use socat.
This also reduces the script runtime.
Signed-off-by: default avatarFlorian Westphal <fw@strlen.de>
Link: https://lore.kernel.org/r/20240418152744.15105-8-fw@strlen.deSigned-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent c0f9a2b7
Hide whitespace changes
Inline Side-by-side
Showing with 75 additions and 118 deletions
tools/testing/selftests/net/netfilter/nft_nat_zones.sh
View file @ d6905f08
...@@ -3,15 +3,14 @@ ...@@ -3,15 +3,14 @@
# Test connection tracking zone and NAT source port reallocation support. # Test connection tracking zone and NAT source port reallocation support.
# #
# Kselftest framework requirement - SKIP code is 4. source lib.sh
ksft_skip=4
# Don't increase too much, 2000 clients should work # Don't increase too much, 2000 clients should work
# just fine but script can then take several minutes with # just fine but script can then take several minutes with
# KASAN/debug builds. # KASAN/debug builds.
maxclients=100 maxclients=100
have_iperf=1 have_socat=0
ret=0 ret=0
# client1---. # client1---.
...@@ -31,12 +30,6 @@ ret=0 ...@@ -31,12 +30,6 @@ ret=0
# NAT Gateway is supposed to do port reallocation for each of the # NAT Gateway is supposed to do port reallocation for each of the
# connections. # connections.
sfx=$(mktemp -u "XXXXXXXX")
gw="ns-gw-$sfx"
cl1="ns-cl1-$sfx"
cl2="ns-cl2-$sfx"
srv="ns-srv-$sfx"
v4gc1=$(sysctl -n net.ipv4.neigh.default.gc_thresh1 2>/dev/null) v4gc1=$(sysctl -n net.ipv4.neigh.default.gc_thresh1 2>/dev/null)
v4gc2=$(sysctl -n net.ipv4.neigh.default.gc_thresh2 2>/dev/null) v4gc2=$(sysctl -n net.ipv4.neigh.default.gc_thresh2 2>/dev/null)
v4gc3=$(sysctl -n net.ipv4.neigh.default.gc_thresh3 2>/dev/null) v4gc3=$(sysctl -n net.ipv4.neigh.default.gc_thresh3 2>/dev/null)
...@@ -46,61 +39,29 @@ v6gc3=$(sysctl -n net.ipv6.neigh.default.gc_thresh3 2>/dev/null) ...@@ -46,61 +39,29 @@ v6gc3=$(sysctl -n net.ipv6.neigh.default.gc_thresh3 2>/dev/null)
cleanup() cleanup()
{ {
ip netns del $gw cleanup_all_ns
ip netns del $srv
for i in $(seq 1 $maxclients); do sysctl -q net.ipv4.neigh.default.gc_thresh1="$v4gc1" 2>/dev/null
ip netns del ns-cl$i-$sfx 2>/dev/null sysctl -q net.ipv4.neigh.default.gc_thresh2="$v4gc2" 2>/dev/null
done sysctl -q net.ipv4.neigh.default.gc_thresh3="$v4gc3" 2>/dev/null
sysctl -q net.ipv6.neigh.default.gc_thresh1="$v6gc1" 2>/dev/null
sysctl -q net.ipv4.neigh.default.gc_thresh1=$v4gc1 2>/dev/null sysctl -q net.ipv6.neigh.default.gc_thresh2="$v6gc2" 2>/dev/null
sysctl -q net.ipv4.neigh.default.gc_thresh2=$v4gc2 2>/dev/null sysctl -q net.ipv6.neigh.default.gc_thresh3="$v6gc3" 2>/dev/null
sysctl -q net.ipv4.neigh.default.gc_thresh3=$v4gc3 2>/dev/null
sysctl -q net.ipv6.neigh.default.gc_thresh1=$v6gc1 2>/dev/null
sysctl -q net.ipv6.neigh.default.gc_thresh2=$v6gc2 2>/dev/null
sysctl -q net.ipv6.neigh.default.gc_thresh3=$v6gc3 2>/dev/null
} }
nft --version > /dev/null 2>&1 checktool "nft --version" echo "run test without nft tool"
if [ $? -ne 0 ];then checktool "conntrack -V" "run test without conntrack tool"
echo "SKIP: Could not run test without nft tool"
exit $ksft_skip
fi
ip -Version > /dev/null 2>&1 if socat -h >/dev/null 2>&1; then
if [ $? -ne 0 ];then have_socat=1
echo "SKIP: Could not run test without ip tool"
exit $ksft_skip
fi fi
conntrack -V > /dev/null 2>&1 setup_ns gw srv
if [ $? -ne 0 ];then
echo "SKIP: Could not run test without conntrack tool"
exit $ksft_skip
fi
iperf3 -v >/dev/null 2>&1
if [ $? -ne 0 ];then
have_iperf=0
fi
ip netns add "$gw"
if [ $? -ne 0 ];then
echo "SKIP: Could not create net namespace $gw"
exit $ksft_skip
fi
ip -net "$gw" link set lo up
trap cleanup EXIT trap cleanup EXIT
ip netns add "$srv"
if [ $? -ne 0 ];then
echo "SKIP: Could not create server netns $srv"
exit $ksft_skip
fi
ip link add veth0 netns "$gw" type veth peer name eth0 netns "$srv" ip link add veth0 netns "$gw" type veth peer name eth0 netns "$srv"
ip -net "$gw" link set veth0 up ip -net "$gw" link set veth0 up
ip -net "$srv" link set lo up
ip -net "$srv" link set eth0 up ip -net "$srv" link set eth0 up
sysctl -q net.ipv6.neigh.default.gc_thresh1=512 2>/dev/null sysctl -q net.ipv6.neigh.default.gc_thresh1=512 2>/dev/null
...@@ -110,55 +71,49 @@ sysctl -q net.ipv4.neigh.default.gc_thresh1=512 2>/dev/null ...@@ -110,55 +71,49 @@ sysctl -q net.ipv4.neigh.default.gc_thresh1=512 2>/dev/null
sysctl -q net.ipv4.neigh.default.gc_thresh2=1024 2>/dev/null sysctl -q net.ipv4.neigh.default.gc_thresh2=1024 2>/dev/null
sysctl -q net.ipv4.neigh.default.gc_thresh3=4096 2>/dev/null sysctl -q net.ipv4.neigh.default.gc_thresh3=4096 2>/dev/null
for i in $(seq 1 $maxclients);do for i in $(seq 1 "$maxclients");do
cl="ns-cl$i-$sfx" setup_ns "cl$i"
ip netns add "$cl" cl=$(eval echo \$cl"$i")
if [ $? -ne 0 ];then if ! ip link add veth"$i" netns "$gw" type veth peer name eth0 netns "$cl" > /dev/null 2>&1;then
echo "SKIP: Could not create client netns $cl"
exit $ksft_skip
fi
ip link add veth$i netns "$gw" type veth peer name eth0 netns "$cl" > /dev/null 2>&1
if [ $? -ne 0 ];then
echo "SKIP: No virtual ethernet pair device support in kernel" echo "SKIP: No virtual ethernet pair device support in kernel"
exit $ksft_skip exit $ksft_skip
fi fi
done done
for i in $(seq 1 $maxclients);do for i in $(seq 1 "$maxclients");do
cl="ns-cl$i-$sfx" cl=$(eval echo \$cl"$i")
echo netns exec "$cl" ip link set lo up
echo netns exec "$cl" ip link set eth0 up echo netns exec "$cl" ip link set eth0 up
echo netns exec "$cl" sysctl -q net.ipv4.tcp_syn_retries=2 echo netns exec "$cl" sysctl -q net.ipv4.tcp_syn_retries=2
echo netns exec "$gw" ip link set veth$i up echo netns exec "$gw" ip link set "veth$i" up
echo netns exec "$gw" sysctl -q net.ipv4.conf.veth$i.arp_ignore=2 echo netns exec "$gw" sysctl -q net.ipv4.conf.veth"$i".arp_ignore=2
echo netns exec "$gw" sysctl -q net.ipv4.conf.veth$i.rp_filter=0 echo netns exec "$gw" sysctl -q net.ipv4.conf.veth"$i".rp_filter=0
# clients have same IP addresses. # clients have same IP addresses.
echo netns exec "$cl" ip addr add 10.1.0.3/24 dev eth0 echo netns exec "$cl" ip addr add 10.1.0.3/24 dev eth0
echo netns exec "$cl" ip addr add dead:1::3/64 dev eth0 echo netns exec "$cl" ip addr add dead:1::3/64 dev eth0 nodad
echo netns exec "$cl" ip route add default via 10.1.0.2 dev eth0 echo netns exec "$cl" ip route add default via 10.1.0.2 dev eth0
echo netns exec "$cl" ip route add default via dead:1::2 dev eth0 echo netns exec "$cl" ip route add default via dead:1::2 dev eth0
# NB: same addresses on client-facing interfaces. # NB: same addresses on client-facing interfaces.
echo netns exec "$gw" ip addr add 10.1.0.2/24 dev veth$i echo netns exec "$gw" ip addr add 10.1.0.2/24 dev "veth$i"
echo netns exec "$gw" ip addr add dead:1::2/64 dev veth$i echo netns exec "$gw" ip addr add dead:1::2/64 dev "veth$i" nodad
# gw: policy routing # gw: policy routing
echo netns exec "$gw" ip route add 10.1.0.0/24 dev veth$i table $((1000+i)) echo netns exec "$gw" ip route add 10.1.0.0/24 dev "veth$i" table $((1000+i))
echo netns exec "$gw" ip route add dead:1::0/64 dev veth$i table $((1000+i)) echo netns exec "$gw" ip route add dead:1::0/64 dev "veth$i" table $((1000+i))
echo netns exec "$gw" ip route add 10.3.0.0/24 dev veth0 table $((1000+i)) echo netns exec "$gw" ip route add 10.3.0.0/24 dev veth0 table $((1000+i))
echo netns exec "$gw" ip route add dead:3::0/64 dev veth0 table $((1000+i)) echo netns exec "$gw" ip route add dead:3::0/64 dev veth0 table $((1000+i))
echo netns exec "$gw" ip rule add fwmark $i lookup $((1000+i)) echo netns exec "$gw" ip rule add fwmark "$i" lookup $((1000+i))
done | ip -batch /dev/stdin done | ip -batch /dev/stdin
ip -net "$gw" addr add 10.3.0.1/24 dev veth0 ip -net "$gw" addr add 10.3.0.1/24 dev veth0
ip -net "$gw" addr add dead:3::1/64 dev veth0 ip -net "$gw" addr add dead:3::1/64 dev veth0 nodad
ip -net "$srv" addr add 10.3.0.99/24 dev eth0 ip -net "$srv" addr add 10.3.0.99/24 dev eth0
ip -net "$srv" addr add dead:3::99/64 dev eth0 ip -net "$srv" addr add dead:3::99/64 dev eth0 nodad
ip netns exec $gw nft -f /dev/stdin<<EOF ip netns exec "$gw" nft -f /dev/stdin<<EOF
table inet raw { table inet raw {
map iiftomark { map iiftomark {
type ifname : mark type ifname : mark
...@@ -203,18 +158,22 @@ table inet raw { ...@@ -203,18 +158,22 @@ table inet raw {
} }
} }
EOF EOF
if [ "$?" -ne 0 ];then
echo "SKIP: Could not add nftables rules"
exit $ksft_skip
fi
( echo add element inet raw iiftomark \{ ( echo add element inet raw iiftomark \{
for i in $(seq 1 $((maxclients-1))); do for i in $(seq 1 $((maxclients-1))); do
echo \"veth$i\" : $i, echo \"veth"$i"\" : "$i",
done done
echo \"veth$maxclients\" : $maxclients \} echo \"veth"$maxclients"\" : "$maxclients" \}
echo add element inet raw iiftozone \{ echo add element inet raw iiftozone \{
for i in $(seq 1 $((maxclients-1))); do for i in $(seq 1 $((maxclients-1))); do
echo \"veth$i\" : $i, echo \"veth"$i"\" : "$i",
done done
echo \"veth$maxclients\" : $maxclients \} echo \"veth$maxclients\" : $maxclients \}
) | ip netns exec $gw nft -f /dev/stdin ) | ip netns exec "$gw" nft -f /dev/stdin
ip netns exec "$gw" sysctl -q net.ipv4.conf.all.forwarding=1 > /dev/null ip netns exec "$gw" sysctl -q net.ipv4.conf.all.forwarding=1 > /dev/null
ip netns exec "$gw" sysctl -q net.ipv6.conf.all.forwarding=1 > /dev/null ip netns exec "$gw" sysctl -q net.ipv6.conf.all.forwarding=1 > /dev/null
...@@ -224,73 +183,72 @@ ip netns exec "$gw" sysctl -q net.ipv4.conf.all.rp_filter=0 >/dev/null ...@@ -224,73 +183,72 @@ ip netns exec "$gw" sysctl -q net.ipv4.conf.all.rp_filter=0 >/dev/null
ip netns exec "$gw" sysctl -q net.ipv4.fwmark_reflect=1 > /dev/null ip netns exec "$gw" sysctl -q net.ipv4.fwmark_reflect=1 > /dev/null
ip netns exec "$gw" sysctl -q net.ipv6.fwmark_reflect=1 > /dev/null ip netns exec "$gw" sysctl -q net.ipv6.fwmark_reflect=1 > /dev/null
for i in $(seq 1 $maxclients); do for i in $(seq 1 "$maxclients"); do
cl="ns-cl$i-$sfx" cl=$(eval echo \$cl"$i")
ip netns exec $cl ping -i 0.5 -q -c 3 10.3.0.99 > /dev/null 2>&1 & ip netns exec "$cl" ping -i 0.5 -q -c 3 10.3.0.99 > /dev/null 2>&1 &
if [ $? -ne 0 ]; then
echo FAIL: Ping failure from $cl 1>&2
ret=1
break
fi
done done
wait wait || ret=1
for i in $(seq 1 $maxclients); do [ "$ret" -ne 0 ] && "FAIL: Ping failure from $cl" 1>&2
ip netns exec $gw nft get element inet raw inicmp "{ 10.1.0.3 . \"veth$i\" . 10.3.0.99 }" | grep -q "{ 10.1.0.3 . \"veth$i\" . 10.3.0.99 counter packets 3 bytes 252 }"
if [ $? -ne 0 ];then for i in $(seq 1 "$maxclients"); do
if ! ip netns exec "$gw" nft get element inet raw inicmp "{ 10.1.0.3 . \"veth$i\" . 10.3.0.99 }" | grep -q "{ 10.1.0.3 . \"veth$i\" . 10.3.0.99 counter packets 3 bytes 252 }"; then
ret=1 ret=1
echo "FAIL: counter icmp mismatch for veth$i" 1>&2 echo "FAIL: counter icmp mismatch for veth$i" 1>&2
ip netns exec $gw nft get element inet raw inicmp "{ 10.1.0.3 . \"veth$i\" . 10.3.0.99 }" 1>&2 ip netns exec "$gw" nft get element inet raw inicmp "{ 10.1.0.3 . \"veth$i\" . 10.3.0.99 }" 1>&2
break break
fi fi
done done
ip netns exec $gw nft get element inet raw inicmp "{ 10.3.0.99 . \"veth0\" . 10.3.0.1 }" | grep -q "{ 10.3.0.99 . \"veth0\" . 10.3.0.1 counter packets $((3 * $maxclients)) bytes $((252 * $maxclients)) }" if ! ip netns exec "$gw" nft get element inet raw inicmp "{ 10.3.0.99 . \"veth0\" . 10.3.0.1 }" | grep -q "{ 10.3.0.99 . \"veth0\" . 10.3.0.1 counter packets $((3 * maxclients)) bytes $((252 * maxclients)) }"; then
if [ $? -ne 0 ];then
ret=1 ret=1
echo "FAIL: counter icmp mismatch for veth0: { 10.3.0.99 . \"veth0\" . 10.3.0.1 counter packets $((3 * $maxclients)) bytes $((252 * $maxclients)) }" echo "FAIL: counter icmp mismatch for veth0: { 10.3.0.99 . \"veth0\" . 10.3.0.1 counter packets $((3 * maxclients)) bytes $((252 * maxclients)) }"
ip netns exec $gw nft get element inet raw inicmp "{ 10.3.99 . \"veth0\" . 10.3.0.1 }" 1>&2 ip netns exec "$gw" nft get element inet raw inicmp "{ 10.3.99 . \"veth0\" . 10.3.0.1 }" 1>&2
fi fi
if [ $ret -eq 0 ]; then if [ $ret -eq 0 ]; then
echo "PASS: ping test from all $maxclients namespaces" echo "PASS: ping test from all $maxclients namespaces"
fi fi
if [ $have_iperf -eq 0 ];then if [ $have_socat -eq 0 ];then
echo "SKIP: iperf3 not installed" echo "SKIP: socat not installed"
if [ $ret -ne 0 ];then if [ $ret -ne 0 ];then
exit $ret exit $ret
fi fi
exit $ksft_skip exit $ksft_skip
fi fi
ip netns exec $srv iperf3 -s > /dev/null 2>&1 & listener_ready()
iperfpid=$! {
sleep 1 ss -N "$1" -lnt -o "sport = :5201" | grep -q 5201
}
ip netns exec "$srv" socat -u TCP-LISTEN:5201,fork STDOUT > /dev/null 2>/dev/null &
socatpid=$!
busywait 1000 listener_ready "$srv"
for i in $(seq 1 $maxclients); do for i in $(seq 1 "$maxclients"); do
if [ $ret -ne 0 ]; then if [ $ret -ne 0 ]; then
break break
fi fi
cl="ns-cl$i-$sfx" cl=$(eval echo \$cl"$i")
ip netns exec $cl iperf3 -c 10.3.0.99 --cport 10000 -n 1 > /dev/null if ! ip netns exec "$cl" socat -4 -u STDIN TCP:10.3.0.99:5201,sourceport=10000 < /dev/null > /dev/null; then
if [ $? -ne 0 ]; then echo "FAIL: Failure to connect for $cl" 1>&2
echo FAIL: Failure to connect for $cl 1>&2 ip netns exec "$gw" conntrack -S 1>&2
ip netns exec $gw conntrack -S 1>&2
ret=1 ret=1
fi fi
done done
if [ $ret -eq 0 ];then if [ $ret -eq 0 ];then
echo "PASS: iperf3 connections for all $maxclients net namespaces" echo "PASS: socat connections for all $maxclients net namespaces"
fi fi
kill $iperfpid kill $socatpid
wait wait
for i in $(seq 1 $maxclients); do for i in $(seq 1 "$maxclients"); do
ip netns exec $gw nft get element inet raw inflows "{ 10.1.0.3 . 10000 . \"veth$i\" . 10.3.0.99 . 5201 }" > /dev/null if ! ip netns exec "$gw" nft get element inet raw inflows "{ 10.1.0.3 . 10000 . \"veth$i\" . 10.3.0.99 . 5201 }" > /dev/null;then
if [ $? -ne 0 ];then
ret=1 ret=1
echo "FAIL: can't find expected tcp entry for veth$i" 1>&2 echo "FAIL: can't find expected tcp entry for veth$i" 1>&2
break break
...@@ -300,8 +258,7 @@ if [ $ret -eq 0 ];then ...@@ -300,8 +258,7 @@ if [ $ret -eq 0 ];then
echo "PASS: Found client connection for all $maxclients net namespaces" echo "PASS: Found client connection for all $maxclients net namespaces"
fi fi
ip netns exec $gw nft get element inet raw inflows "{ 10.3.0.99 . 5201 . \"veth0\" . 10.3.0.1 . 10000 }" > /dev/null if ! ip netns exec "$gw" nft get element inet raw inflows "{ 10.3.0.99 . 5201 . \"veth0\" . 10.3.0.1 . 10000 }" > /dev/null;then
if [ $? -ne 0 ];then
ret=1 ret=1
echo "FAIL: cannot find return entry on veth0" 1>&2 echo "FAIL: cannot find return entry on veth0" 1>&2
fi fi
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7