Commit d6b4991a authored by Herbert Xu's avatar Herbert Xu Committed by David S. Miller

[NET]: Fix logical error in skb_gso_ok

The test in skb_gso_ok is backwards.  Noticed by Michael Chan
<mchan@broadcom.com>.
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
Acked-by: default avatarMichael Chan <mchan@broadcom.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 4ee303df
...@@ -994,12 +994,12 @@ static inline int skb_gso_ok(struct sk_buff *skb, int features) ...@@ -994,12 +994,12 @@ static inline int skb_gso_ok(struct sk_buff *skb, int features)
{ {
int feature = skb_shinfo(skb)->gso_size ? int feature = skb_shinfo(skb)->gso_size ?
skb_shinfo(skb)->gso_type << NETIF_F_GSO_SHIFT : 0; skb_shinfo(skb)->gso_type << NETIF_F_GSO_SHIFT : 0;
return (features & feature) != feature; return (features & feature) == feature;
} }
static inline int netif_needs_gso(struct net_device *dev, struct sk_buff *skb) static inline int netif_needs_gso(struct net_device *dev, struct sk_buff *skb)
{ {
return skb_gso_ok(skb, dev->features); return !skb_gso_ok(skb, dev->features);
} }
#endif /* __KERNEL__ */ #endif /* __KERNEL__ */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment