Commit d91680ef authored by Imre Deak's avatar Imre Deak

drm/i915/dp_mst: Enable FEC early once it's known DSC is needed

Enable FEC in crtc_state, as soon as it's known it will be needed by
DSC. This fixes the calculation of BW allocation overhead, in case DSC
is enabled by falling back to it during the encoder compute config
phase (vs. enabling FEC due to DSC being enabled on other streams).

v2:
- Enable FEC only in intel_dp_mst_find_vcpi_slots_for_bpp(), since
  only by that will crtc_state->port_clock be set, which in turn is
  needed by intel_dp_is_uhbr().

Reviewed-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com> (v1)
Signed-off-by: default avatarImre Deak <imre.deak@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20231030155843.2251023-11-imre.deak@intel.com
parent c1d6a22b
...@@ -1369,7 +1369,7 @@ static bool intel_dp_source_supports_fec(struct intel_dp *intel_dp, ...@@ -1369,7 +1369,7 @@ static bool intel_dp_source_supports_fec(struct intel_dp *intel_dp,
return false; return false;
} }
static bool intel_dp_supports_fec(struct intel_dp *intel_dp, bool intel_dp_supports_fec(struct intel_dp *intel_dp,
const struct intel_connector *connector, const struct intel_connector *connector,
const struct intel_crtc_state *pipe_config) const struct intel_crtc_state *pipe_config)
{ {
......
...@@ -137,6 +137,11 @@ static inline unsigned int intel_dp_unused_lane_mask(int lane_count) ...@@ -137,6 +137,11 @@ static inline unsigned int intel_dp_unused_lane_mask(int lane_count)
} }
u32 intel_dp_mode_to_fec_clock(u32 mode_clock); u32 intel_dp_mode_to_fec_clock(u32 mode_clock);
bool intel_dp_supports_fec(struct intel_dp *intel_dp,
const struct intel_connector *connector,
const struct intel_crtc_state *pipe_config);
u32 intel_dp_dsc_nearest_valid_bpp(struct drm_i915_private *i915, u32 bpp, u32 pipe_bpp); u32 intel_dp_dsc_nearest_valid_bpp(struct drm_i915_private *i915, u32 bpp, u32 pipe_bpp);
void intel_ddi_update_pipe(struct intel_atomic_state *state, void intel_ddi_update_pipe(struct intel_atomic_state *state,
......
...@@ -95,6 +95,13 @@ static int intel_dp_mst_find_vcpi_slots_for_bpp(struct intel_encoder *encoder, ...@@ -95,6 +95,13 @@ static int intel_dp_mst_find_vcpi_slots_for_bpp(struct intel_encoder *encoder,
crtc_state->lane_count = limits->max_lane_count; crtc_state->lane_count = limits->max_lane_count;
crtc_state->port_clock = limits->max_rate; crtc_state->port_clock = limits->max_rate;
if (dsc) {
if (!intel_dp_supports_fec(intel_dp, connector, crtc_state))
return -EINVAL;
crtc_state->fec_enable = !intel_dp_is_uhbr(crtc_state);
}
mst_state->pbn_div = drm_dp_get_vc_payload_bw(&intel_dp->mst_mgr, mst_state->pbn_div = drm_dp_get_vc_payload_bw(&intel_dp->mst_mgr,
crtc_state->port_clock, crtc_state->port_clock,
crtc_state->lane_count); crtc_state->lane_count);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment