Commit da244427 authored by Yang Li's avatar Yang Li Committed by Mauro Carvalho Chehab

media: exynos4-is: add missing call to of_node_put()

In one of the error paths of the for_each_child_of_node() loop in
fimc_md_parse_one_endpoint, add missing call to of_node_put().

Fix the following coccicheck warning:
./drivers/media/platform/exynos4-is/media-dev.c:489:1-23: WARNING:
Function "for_each_child_of_node" should have of_node_put() before
return around line 492.
Reported-by: default avatarAbaci Robot <abaci@linux.alibaba.com>
Signed-off-by: default avatarYang Li <yang.lee@linux.alibaba.com>
Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
parent 1a28dce2
...@@ -488,9 +488,11 @@ static int fimc_md_parse_port_node(struct fimc_md *fmd, ...@@ -488,9 +488,11 @@ static int fimc_md_parse_port_node(struct fimc_md *fmd,
for_each_child_of_node(port, ep) { for_each_child_of_node(port, ep) {
ret = fimc_md_parse_one_endpoint(fmd, ep); ret = fimc_md_parse_one_endpoint(fmd, ep);
if (ret < 0) if (ret < 0) {
of_node_put(ep);
return ret; return ret;
} }
}
return 0; return 0;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment