Commit db08948b authored by Wei Yongjun's avatar Wei Yongjun Committed by Greg Kroah-Hartman

vme: fake: remove unexpected unlock in fake_master_set()

image->lock is unlocked in some error handling path without take the
lock, so remove those unexpected unlock.

Fixes: 658bcdae ("vme: Adding Fake VME driver")
Signed-off-by: default avatarWei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 58ccaae3
...@@ -273,7 +273,6 @@ static int fake_master_set(struct vme_master_resource *image, int enabled, ...@@ -273,7 +273,6 @@ static int fake_master_set(struct vme_master_resource *image, int enabled,
} }
if (size & 0xFFFF) { if (size & 0xFFFF) {
spin_unlock(&image->lock);
pr_err("Invalid size alignment\n"); pr_err("Invalid size alignment\n");
retval = -EINVAL; retval = -EINVAL;
goto err_window; goto err_window;
...@@ -292,7 +291,6 @@ static int fake_master_set(struct vme_master_resource *image, int enabled, ...@@ -292,7 +291,6 @@ static int fake_master_set(struct vme_master_resource *image, int enabled,
case VME_D32: case VME_D32:
break; break;
default: default:
spin_unlock(&image->lock);
pr_err("Invalid data width\n"); pr_err("Invalid data width\n");
retval = -EINVAL; retval = -EINVAL;
goto err_dwidth; goto err_dwidth;
...@@ -311,7 +309,6 @@ static int fake_master_set(struct vme_master_resource *image, int enabled, ...@@ -311,7 +309,6 @@ static int fake_master_set(struct vme_master_resource *image, int enabled,
case VME_USER4: case VME_USER4:
break; break;
default: default:
spin_unlock(&image->lock);
pr_err("Invalid address space\n"); pr_err("Invalid address space\n");
retval = -EINVAL; retval = -EINVAL;
goto err_aspace; goto err_aspace;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment