Commit dbc6e7d4 authored by Nanyong Sun's avatar Nanyong Sun Committed by Linus Torvalds

nilfs2: fix NULL pointer in nilfs_##name##_attr_release

In nilfs_##name##_attr_release, kobj->parent should not be referenced
because it is a NULL pointer.  The release() method of kobject is always
called in kobject_put(kobj), in the implementation of kobject_put(), the
kobj->parent will be assigned as NULL before call the release() method.
So just use kobj to get the subgroups, which is more efficient and can fix
a NULL pointer reference problem.

Link: https://lkml.kernel.org/r/20210629022556.3985106-3-sunnanyong@huawei.com
Link: https://lkml.kernel.org/r/1625651306-10829-3-git-send-email-konishi.ryusuke@gmail.comSigned-off-by: default avatarNanyong Sun <sunnanyong@huawei.com>
Signed-off-by: default avatarRyusuke Konishi <konishi.ryusuke@gmail.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 5f5dec07
...@@ -51,11 +51,9 @@ static const struct sysfs_ops nilfs_##name##_attr_ops = { \ ...@@ -51,11 +51,9 @@ static const struct sysfs_ops nilfs_##name##_attr_ops = { \
#define NILFS_DEV_INT_GROUP_TYPE(name, parent_name) \ #define NILFS_DEV_INT_GROUP_TYPE(name, parent_name) \
static void nilfs_##name##_attr_release(struct kobject *kobj) \ static void nilfs_##name##_attr_release(struct kobject *kobj) \
{ \ { \
struct nilfs_sysfs_##parent_name##_subgroups *subgroups; \ struct nilfs_sysfs_##parent_name##_subgroups *subgroups = container_of(kobj, \
struct the_nilfs *nilfs = container_of(kobj->parent, \ struct nilfs_sysfs_##parent_name##_subgroups, \
struct the_nilfs, \ sg_##name##_kobj); \
ns_##parent_name##_kobj); \
subgroups = nilfs->ns_##parent_name##_subgroups; \
complete(&subgroups->sg_##name##_kobj_unregister); \ complete(&subgroups->sg_##name##_kobj_unregister); \
} \ } \
static struct kobj_type nilfs_##name##_ktype = { \ static struct kobj_type nilfs_##name##_ktype = { \
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment