Commit dc89f797 authored by Laurent Pinchart's avatar Laurent Pinchart Committed by Joerg Roedel

iommu/shmobile: Allocate archdata with kzalloc()

The archdata attached_list field isn't initialized, leading to random
crashes when accessed. Use kzalloc() to allocate the whole structure and
make sure all fields get initialized properly.
Signed-off-by: default avatarLaurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Signed-off-by: default avatarJoerg Roedel <joro@8bytes.org>
parent 78a2e12f
...@@ -380,14 +380,13 @@ int ipmmu_iommu_init(struct shmobile_ipmmu *ipmmu) ...@@ -380,14 +380,13 @@ int ipmmu_iommu_init(struct shmobile_ipmmu *ipmmu)
kmem_cache_destroy(l1cache); kmem_cache_destroy(l1cache);
return -ENOMEM; return -ENOMEM;
} }
archdata = kmalloc(sizeof(*archdata), GFP_KERNEL); archdata = kzalloc(sizeof(*archdata), GFP_KERNEL);
if (!archdata) { if (!archdata) {
kmem_cache_destroy(l1cache); kmem_cache_destroy(l1cache);
kmem_cache_destroy(l2cache); kmem_cache_destroy(l2cache);
return -ENOMEM; return -ENOMEM;
} }
spin_lock_init(&archdata->attach_lock); spin_lock_init(&archdata->attach_lock);
archdata->attached = NULL;
archdata->ipmmu = ipmmu; archdata->ipmmu = ipmmu;
ipmmu_archdata = archdata; ipmmu_archdata = archdata;
bus_set_iommu(&platform_bus_type, &shmobile_iommu_ops); bus_set_iommu(&platform_bus_type, &shmobile_iommu_ops);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment