Commit dd64c151 authored by Jiri Kosina's avatar Jiri Kosina

HID: move away from DEBUG defines in favor of CONFIG_HID_DEBUG

CONFIG_INPUT_DEBUG is non-existent option, so remove anything depending
on it.

Also, as we have new CONFIG_HID_DEBUG, this should be used on places
where ifdef DEBUG was used before.

Suggested by Adrian Bunk.
Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
parent 43c7bf04
# #
# Makefile for the HID driver # Makefile for the HID driver
# #
# Multipart objects.
hid-objs := hid-core.o hid-input.o hid-objs := hid-core.o hid-input.o
# Optional parts of multipart objects.
ifeq ($(CONFIG_HID_DEBUG),y)
hid-objs += hid-debug.o
endif
ifeq ($(CONFIG_INPUT_DEBUG),y)
EXTRA_CFLAGS += -DDEBUG
endif
obj-$(CONFIG_HID) += hid.o obj-$(CONFIG_HID) += hid.o
hid-$(CONFIG_HID_DEBUG) += hid-debug.o
...@@ -28,8 +28,6 @@ ...@@ -28,8 +28,6 @@
#include <linux/input.h> #include <linux/input.h>
#include <linux/wait.h> #include <linux/wait.h>
#undef DEBUG_DATA
#include <linux/hid.h> #include <linux/hid.h>
#include <linux/hiddev.h> #include <linux/hiddev.h>
#include <linux/hid-debug.h> #include <linux/hid-debug.h>
...@@ -951,7 +949,7 @@ int hid_input_report(struct hid_device *hid, int type, u8 *data, int size, int i ...@@ -951,7 +949,7 @@ int hid_input_report(struct hid_device *hid, int type, u8 *data, int size, int i
return -1; return -1;
} }
#ifdef DEBUG_DATA #ifdef CONFIG_HID_DEBUG
printk(KERN_DEBUG __FILE__ ": report (size %u) (%snumbered)\n", size, report_enum->numbered ? "" : "un"); printk(KERN_DEBUG __FILE__ ": report (size %u) (%snumbered)\n", size, report_enum->numbered ? "" : "un");
#endif #endif
...@@ -961,7 +959,7 @@ int hid_input_report(struct hid_device *hid, int type, u8 *data, int size, int i ...@@ -961,7 +959,7 @@ int hid_input_report(struct hid_device *hid, int type, u8 *data, int size, int i
size--; size--;
} }
#ifdef DEBUG_DATA #ifdef CONFIG_HID_DEBUG
{ {
int i; int i;
printk(KERN_DEBUG __FILE__ ": report %d (size %u) = ", n, size); printk(KERN_DEBUG __FILE__ ": report %d (size %u) = ", n, size);
......
...@@ -28,7 +28,6 @@ ...@@ -28,7 +28,6 @@
* Vojtech Pavlik, Simunkova 1594, Prague 8, 182 00 Czech Republic * Vojtech Pavlik, Simunkova 1594, Prague 8, 182 00 Czech Republic
*/ */
//#include <linux/input.h>
#include <linux/hid.h> #include <linux/hid.h>
struct hid_usage_entry { struct hid_usage_entry {
......
...@@ -31,8 +31,6 @@ ...@@ -31,8 +31,6 @@
#include <linux/slab.h> #include <linux/slab.h>
#include <linux/kernel.h> #include <linux/kernel.h>
#undef DEBUG
#include <linux/hid.h> #include <linux/hid.h>
#include <linux/hid-debug.h> #include <linux/hid-debug.h>
...@@ -253,7 +251,7 @@ static void hidinput_configure_usage(struct hid_input *hidinput, struct hid_fiel ...@@ -253,7 +251,7 @@ static void hidinput_configure_usage(struct hid_input *hidinput, struct hid_fiel
field->hidinput = hidinput; field->hidinput = hidinput;
#ifdef DEBUG #ifdef CONFIG_HID_DEBUG
printk(KERN_DEBUG "Mapping: "); printk(KERN_DEBUG "Mapping: ");
hid_resolv_usage(usage->hid); hid_resolv_usage(usage->hid);
printk(" ---> "); printk(" ---> ");
...@@ -690,7 +688,7 @@ static void hidinput_configure_usage(struct hid_input *hidinput, struct hid_fiel ...@@ -690,7 +688,7 @@ static void hidinput_configure_usage(struct hid_input *hidinput, struct hid_fiel
return; return;
ignore: ignore:
#ifdef DEBUG #ifdef CONFIG_HID_DEBUG
printk("IGNORED\n"); printk("IGNORED\n");
#endif #endif
return; return;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment