Commit de0f49b8 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Mark Brown

ALSA: sh: aica: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: default avatarTakashi Iwai <tiwai@suse.de>
Acked-by: default avatarNicolas Ferre <nicolas.ferre@microchip.com>
Link: https://lore.kernel.org/r/20230315150745.67084-12-u.kleine-koenig@pengutronix.deSigned-off-by: default avatarMark Brown <broonie@kernel.org>
parent c3d8cb19
...@@ -539,13 +539,12 @@ static int add_aicamixer_controls(struct snd_card_aica *dreamcastcard) ...@@ -539,13 +539,12 @@ static int add_aicamixer_controls(struct snd_card_aica *dreamcastcard)
return 0; return 0;
} }
static int snd_aica_remove(struct platform_device *devptr) static void snd_aica_remove(struct platform_device *devptr)
{ {
struct snd_card_aica *dreamcastcard; struct snd_card_aica *dreamcastcard;
dreamcastcard = platform_get_drvdata(devptr); dreamcastcard = platform_get_drvdata(devptr);
snd_card_free(dreamcastcard->card); snd_card_free(dreamcastcard->card);
kfree(dreamcastcard); kfree(dreamcastcard);
return 0;
} }
static int snd_aica_probe(struct platform_device *devptr) static int snd_aica_probe(struct platform_device *devptr)
...@@ -592,7 +591,7 @@ static int snd_aica_probe(struct platform_device *devptr) ...@@ -592,7 +591,7 @@ static int snd_aica_probe(struct platform_device *devptr)
static struct platform_driver snd_aica_driver = { static struct platform_driver snd_aica_driver = {
.probe = snd_aica_probe, .probe = snd_aica_probe,
.remove = snd_aica_remove, .remove_new = snd_aica_remove,
.driver = { .driver = {
.name = SND_AICA_DRIVER, .name = SND_AICA_DRIVER,
}, },
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment