Commit dee0586e authored by Dan Carpenter's avatar Dan Carpenter Committed by James Bottomley

sd: fix an error return in probe()

If device_add() fails then it should return the error code but instead
the current code returns success.
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: default avatarTomas Henzl <thenzl@redhat.com>
Signed-off-by: default avatarJames Bottomley <JBottomley@Odin.com>
parent ef10b169
...@@ -2988,7 +2988,8 @@ static int sd_probe(struct device *dev) ...@@ -2988,7 +2988,8 @@ static int sd_probe(struct device *dev)
sdkp->dev.class = &sd_disk_class; sdkp->dev.class = &sd_disk_class;
dev_set_name(&sdkp->dev, "%s", dev_name(dev)); dev_set_name(&sdkp->dev, "%s", dev_name(dev));
if (device_add(&sdkp->dev)) error = device_add(&sdkp->dev);
if (error)
goto out_free_index; goto out_free_index;
get_device(dev); get_device(dev);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment