Commit df11f7dd authored by Aaron Lewis's avatar Aaron Lewis Committed by Paolo Bonzini

selftests: kvm: Fix the segment descriptor layout to match the actual layout

Fix the layout of 'struct desc64' to match the layout described in the
SDM Vol 3, Chapter 3 "Protected-Mode Memory Management", section 3.4.5
"Segment Descriptors", Figure 3-8 "Segment Descriptor".  The test added
later in this series relies on this and crashes if this layout is not
correct.
Signed-off-by: default avatarAaron Lewis <aaronlewis@google.com>
Reviewed-by: default avatarAlexander Graf <graf@amazon.com>
Message-Id: <20201012194716.3950330-2-aaronlewis@google.com>
Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
parent 2cdef91c
...@@ -59,7 +59,7 @@ struct gpr64_regs { ...@@ -59,7 +59,7 @@ struct gpr64_regs {
struct desc64 { struct desc64 {
uint16_t limit0; uint16_t limit0;
uint16_t base0; uint16_t base0;
unsigned base1:8, s:1, type:4, dpl:2, p:1; unsigned base1:8, type:4, s:1, dpl:2, p:1;
unsigned limit1:4, avl:1, l:1, db:1, g:1, base2:8; unsigned limit1:4, avl:1, l:1, db:1, g:1, base2:8;
uint32_t base3; uint32_t base3;
uint32_t zero1; uint32_t zero1;
......
...@@ -392,11 +392,12 @@ static void kvm_seg_fill_gdt_64bit(struct kvm_vm *vm, struct kvm_segment *segp) ...@@ -392,11 +392,12 @@ static void kvm_seg_fill_gdt_64bit(struct kvm_vm *vm, struct kvm_segment *segp)
desc->limit0 = segp->limit & 0xFFFF; desc->limit0 = segp->limit & 0xFFFF;
desc->base0 = segp->base & 0xFFFF; desc->base0 = segp->base & 0xFFFF;
desc->base1 = segp->base >> 16; desc->base1 = segp->base >> 16;
desc->s = segp->s;
desc->type = segp->type; desc->type = segp->type;
desc->s = segp->s;
desc->dpl = segp->dpl; desc->dpl = segp->dpl;
desc->p = segp->present; desc->p = segp->present;
desc->limit1 = segp->limit >> 16; desc->limit1 = segp->limit >> 16;
desc->avl = segp->avl;
desc->l = segp->l; desc->l = segp->l;
desc->db = segp->db; desc->db = segp->db;
desc->g = segp->g; desc->g = segp->g;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment