Commit e4b0c50a authored by Andrew Morton's avatar Andrew Morton Committed by Linus Torvalds

[PATCH] digi_acceleport.c has bogus "address of" operator

From: "Kurtis D. Rader" <kdrader@us.ibm.com>

http://bugme.osdl.org/show_bug.cgi?id=1365

The digi_acceleport.c USB serial driver has a bogus "address of" operator
that results in BUGs.

The problem is that digi_wakeup_write_lock() takes a pointer to a struct
usb_serial_port.  However, what gets passed is a pointer to a pointer to a
struct usb_serial_port.
parent 49c69171
...@@ -1728,8 +1728,8 @@ dbg( "digi_startup: TOP" ); ...@@ -1728,8 +1728,8 @@ dbg( "digi_startup: TOP" );
init_waitqueue_head( &priv->dp_flush_wait ); init_waitqueue_head( &priv->dp_flush_wait );
priv->dp_in_close = 0; priv->dp_in_close = 0;
init_waitqueue_head( &priv->dp_close_wait ); init_waitqueue_head( &priv->dp_close_wait );
INIT_WORK(&priv->dp_wakeup_work, (void *)digi_wakeup_write_lock, INIT_WORK(&priv->dp_wakeup_work,
(void *)(&serial->port[i])); digi_wakeup_write_lock, serial->port[i]);
/* initialize write wait queue for this port */ /* initialize write wait queue for this port */
init_waitqueue_head( &serial->port[i]->write_wait ); init_waitqueue_head( &serial->port[i]->write_wait );
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment