Commit e543ad76 authored by Steven Rostedt's avatar Steven Rostedt

tracing: add cpu_file intialization for ftrace_dump

Impact: fix to ftrace_dump output corruption

The commit: b04cc6b1
  tracing/core: introduce per cpu tracing files

added a new field to the iterator called cpu_file. This was a handle
to differentiate between the per cpu trace output files and the
all cpu "trace" file. The all cpu "trace" file required setting this
to TRACE_PIPE_ALL_CPU.

The problem is that the ftrace_dump sets up its own iterator but was
not updated to handle this change. The result was only CPU 0 printing
out on crash and a lot of "<0>"'s also being printed.
Reported-by: default avatarThomas Gleixner <tglx@linuxtronix.de>
Tested-by: default avatarDarren Hart <dvhtc@us.ibm.com>
Signed-off-by: default avatarSteven Rostedt <srostedt@redhat.com>
parent efed792d
...@@ -3918,8 +3918,10 @@ void ftrace_dump(void) ...@@ -3918,8 +3918,10 @@ void ftrace_dump(void)
printk(KERN_TRACE "Dumping ftrace buffer:\n"); printk(KERN_TRACE "Dumping ftrace buffer:\n");
/* Simulate the iterator */
iter.tr = &global_trace; iter.tr = &global_trace;
iter.trace = current_trace; iter.trace = current_trace;
iter.cpu_file = TRACE_PIPE_ALL_CPU;
/* /*
* We need to stop all tracing on all CPUS to read the * We need to stop all tracing on all CPUS to read the
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment