Commit e676ccd7 authored by Johan Hovold's avatar Johan Hovold Committed by Greg Kroah-Hartman

greybus: svc: print an error message on failed eject attempts

Print an error message when the SVC fails to eject an interface.
Signed-off-by: default avatarJohan Hovold <johan@hovoldconsulting.com>
Reviewed-by: default avatarJeffrey Carlyle <jcarlyle@google.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@google.com>
parent c80514a3
...@@ -131,6 +131,7 @@ EXPORT_SYMBOL_GPL(gb_svc_intf_reset); ...@@ -131,6 +131,7 @@ EXPORT_SYMBOL_GPL(gb_svc_intf_reset);
int gb_svc_intf_eject(struct gb_svc *svc, u8 intf_id) int gb_svc_intf_eject(struct gb_svc *svc, u8 intf_id)
{ {
struct gb_svc_intf_eject_request request; struct gb_svc_intf_eject_request request;
int ret;
request.intf_id = intf_id; request.intf_id = intf_id;
...@@ -138,10 +139,16 @@ int gb_svc_intf_eject(struct gb_svc *svc, u8 intf_id) ...@@ -138,10 +139,16 @@ int gb_svc_intf_eject(struct gb_svc *svc, u8 intf_id)
* The pulse width for module release in svc is long so we need to * The pulse width for module release in svc is long so we need to
* increase the timeout so the operation will not return to soon. * increase the timeout so the operation will not return to soon.
*/ */
return gb_operation_sync_timeout(svc->connection, ret = gb_operation_sync_timeout(svc->connection,
GB_SVC_TYPE_INTF_EJECT, &request, GB_SVC_TYPE_INTF_EJECT, &request,
sizeof(request), NULL, 0, sizeof(request), NULL, 0,
GB_SVC_EJECT_TIME); GB_SVC_EJECT_TIME);
if (ret) {
dev_err(&svc->dev, "failed to eject interface %u\n", intf_id);
return ret;
}
return 0;
} }
int gb_svc_dme_peer_get(struct gb_svc *svc, u8 intf_id, u16 attr, u16 selector, int gb_svc_dme_peer_get(struct gb_svc *svc, u8 intf_id, u16 attr, u16 selector,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment