Commit e7385de5 authored by Gregor Boirie's avatar Gregor Boirie Committed by Jonathan Cameron

iio:st_sensors: align on storagebits boundaries

Ensure triggered buffering memory accesses are properly aligned on per
channel storagebits boundaries.
Signed-off-by: default avatarGregor Boirie <gregor.boirie@parrot.com>
Tested-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Signed-off-by: default avatarJonathan Cameron <jic23@kernel.org>
parent fc6bd727
...@@ -24,30 +24,29 @@ ...@@ -24,30 +24,29 @@
static int st_sensors_get_buffer_element(struct iio_dev *indio_dev, u8 *buf) static int st_sensors_get_buffer_element(struct iio_dev *indio_dev, u8 *buf)
{ {
int i, len; int i;
int total = 0;
struct st_sensor_data *sdata = iio_priv(indio_dev); struct st_sensor_data *sdata = iio_priv(indio_dev);
unsigned int num_data_channels = sdata->num_data_channels; unsigned int num_data_channels = sdata->num_data_channels;
for (i = 0; i < num_data_channels; i++) { for_each_set_bit(i, indio_dev->active_scan_mask, num_data_channels) {
unsigned int bytes_to_read; const struct iio_chan_spec *channel = &indio_dev->channels[i];
unsigned int bytes_to_read = channel->scan_type.realbits >> 3;
if (test_bit(i, indio_dev->active_scan_mask)) { unsigned int storage_bytes =
bytes_to_read = indio_dev->channels[i].scan_type.storagebits >> 3; channel->scan_type.storagebits >> 3;
len = sdata->tf->read_multiple_byte(&sdata->tb,
sdata->dev, indio_dev->channels[i].address, buf = PTR_ALIGN(buf, storage_bytes);
bytes_to_read, if (sdata->tf->read_multiple_byte(&sdata->tb, sdata->dev,
buf + total, sdata->multiread_bit); channel->address,
bytes_to_read, buf,
if (len < bytes_to_read) sdata->multiread_bit) <
bytes_to_read)
return -EIO; return -EIO;
/* Advance the buffer pointer */ /* Advance the buffer pointer */
total += len; buf += storage_bytes;
}
} }
return total; return 0;
} }
irqreturn_t st_sensors_trigger_handler(int irq, void *p) irqreturn_t st_sensors_trigger_handler(int irq, void *p)
......
...@@ -490,7 +490,7 @@ static int st_sensors_read_axis_data(struct iio_dev *indio_dev, ...@@ -490,7 +490,7 @@ static int st_sensors_read_axis_data(struct iio_dev *indio_dev,
int err; int err;
u8 *outdata; u8 *outdata;
struct st_sensor_data *sdata = iio_priv(indio_dev); struct st_sensor_data *sdata = iio_priv(indio_dev);
unsigned int byte_for_channel = ch->scan_type.storagebits >> 3; unsigned int byte_for_channel = ch->scan_type.realbits >> 3;
outdata = kmalloc(byte_for_channel, GFP_KERNEL); outdata = kmalloc(byte_for_channel, GFP_KERNEL);
if (!outdata) if (!outdata)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment