Commit ed08ebb7 authored by Guenter Roeck's avatar Guenter Roeck

hwmon: (drivetemp) Return -ENODATA for invalid temperatures

Holger Hoffstätte observed that Samsung 850 Pro may return invalid
temperatures for a short period of time after resume. Return -ENODATA
to userspace if this is observed.

Fixes:  5b46903d ("hwmon: Driver for disk and solid state drives with temperature sensors")
Reported-by: default avatarHolger Hoffstätte <holger@applied-asynchrony.com>
Cc: Holger Hoffstätte <holger@applied-asynchrony.com>
Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
parent 6bdf8f3e
...@@ -264,12 +264,18 @@ static int drivetemp_get_scttemp(struct drivetemp_data *st, u32 attr, long *val) ...@@ -264,12 +264,18 @@ static int drivetemp_get_scttemp(struct drivetemp_data *st, u32 attr, long *val)
return err; return err;
switch (attr) { switch (attr) {
case hwmon_temp_input: case hwmon_temp_input:
if (!temp_is_valid(buf[SCT_STATUS_TEMP]))
return -ENODATA;
*val = temp_from_sct(buf[SCT_STATUS_TEMP]); *val = temp_from_sct(buf[SCT_STATUS_TEMP]);
break; break;
case hwmon_temp_lowest: case hwmon_temp_lowest:
if (!temp_is_valid(buf[SCT_STATUS_TEMP_LOWEST]))
return -ENODATA;
*val = temp_from_sct(buf[SCT_STATUS_TEMP_LOWEST]); *val = temp_from_sct(buf[SCT_STATUS_TEMP_LOWEST]);
break; break;
case hwmon_temp_highest: case hwmon_temp_highest:
if (!temp_is_valid(buf[SCT_STATUS_TEMP_HIGHEST]))
return -ENODATA;
*val = temp_from_sct(buf[SCT_STATUS_TEMP_HIGHEST]); *val = temp_from_sct(buf[SCT_STATUS_TEMP_HIGHEST]);
break; break;
default: default:
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment