Skip to content

L
linux
Commit ee41779e authored by Ben Skeggs's avatar Ben Skeggs
Browse files
Options

drm/nvd0/disp: rewrite irq handler, should be somewhat sturdier now 

Signed-off-by: default avatarBen Skeggs <bskeggs@redhat.com>
parent f20ce962
Show whitespace changes
Inline Side-by-side
Showing with 111 additions and 81 deletions
drivers/gpu/drm/nouveau/nvd0_display.c
View file @ ee41779e
...@@ -46,14 +46,7 @@ struct nvd0_display { ...@@ -46,14 +46,7 @@ struct nvd0_display {
} evo[1]; } evo[1];
struct tasklet_struct tasklet; struct tasklet_struct tasklet;
struct {
struct dcb_entry *dis;
struct dcb_entry *ena;
u32 modeset; u32 modeset;
int crtc;
int pclk;
u16 cfg;
} irq;
}; };
static struct nvd0_display * static struct nvd0_display *
...@@ -965,6 +958,23 @@ nvd0_sor_create(struct drm_connector *connector, struct dcb_entry *dcbe) ...@@ -965,6 +958,23 @@ nvd0_sor_create(struct drm_connector *connector, struct dcb_entry *dcbe)
/****************************************************************************** /******************************************************************************
* IRQ * IRQ
*****************************************************************************/ *****************************************************************************/
static void
debug_irq(struct drm_device *dev, int i)
{
if (drm_debug & (DRM_UT_DRIVER | DRM_UT_KMS)) {
NV_INFO(dev, "PDISP: modeset req %d\n", i);
NV_INFO(dev, " STAT: 0x%08x 0x%08x 0x%08x\n",
nv_rd32(dev, 0x6101d0),
nv_rd32(dev, 0x6101d4), nv_rd32(dev, 0x6109d4));
for (i = 0; i < 8; i++) {
NV_INFO(dev, " %s%d: 0x%08x 0x%08x\n",
i < 4 ? "DAC" : "SOR", i,
nv_rd32(dev, 0x640180 + (i * 0x20)),
nv_rd32(dev, 0x660180 + (i * 0x20)));
}
}
}
static struct dcb_entry * static struct dcb_entry *
lookup_dcb(struct drm_device *dev, int id, u32 mc) lookup_dcb(struct drm_device *dev, int id, u32 mc)
{ {
...@@ -981,6 +991,7 @@ lookup_dcb(struct drm_device *dev, int id, u32 mc) ...@@ -981,6 +991,7 @@ lookup_dcb(struct drm_device *dev, int id, u32 mc)
case 0x00000200: type = OUTPUT_TMDS; break; case 0x00000200: type = OUTPUT_TMDS; break;
case 0x00000500: type = OUTPUT_TMDS; break; case 0x00000500: type = OUTPUT_TMDS; break;
default: default:
NV_ERROR(dev, "PDISP: unknown SOR mc 0x%08x\n", mc);
return NULL; return NULL;
} }
...@@ -993,49 +1004,36 @@ lookup_dcb(struct drm_device *dev, int id, u32 mc) ...@@ -993,49 +1004,36 @@ lookup_dcb(struct drm_device *dev, int id, u32 mc)
return dcb; return dcb;
} }
NV_INFO(dev, "PDISP: DCB for %d/0x%08x not found\n", id, mc); NV_ERROR(dev, "PDISP: DCB for %d/0x%08x not found\n", id, mc);
return NULL; return NULL;
} }
static void static void
nvd0_display_unk1_handler(struct drm_device *dev) nvd0_display_unk1_handler(struct drm_device *dev)
{ {
struct nvd0_display *disp = nvd0_display(dev);
struct dcb_entry *dcb; struct dcb_entry *dcb;
u32 unkn, crtc = 0; u32 mask, crtc;
int i; int i;
NV_INFO(dev, "PDISP: 1 0x%08x 0x%08x 0x%08x\n", nv_rd32(dev, 0x6101d0), mask = nv_rd32(dev, 0x6101d4);
nv_rd32(dev, 0x6101d4), nv_rd32(dev, 0x6109d4)); crtc = 0;
if (!mask) {
unkn = nv_rd32(dev, 0x6101d4); mask = nv_rd32(dev, 0x6109d4);
if (!unkn) {
unkn = nv_rd32(dev, 0x6109d4);
crtc = 1; crtc = 1;
} }
debug_irq(dev, 1);
disp->irq.ena = NULL; for (i = 0; mask && i < 8; i++) {
disp->irq.dis = NULL;
disp->irq.crtc = crtc;
disp->irq.pclk = nv_rd32(dev, 0x660450 + (disp->irq.crtc * 0x300));
disp->irq.pclk /= 1000;
for (i = 0; i < 8; i++) {
u32 mcc = nv_rd32(dev, 0x640180 + (i * 0x20)); u32 mcc = nv_rd32(dev, 0x640180 + (i * 0x20));
u32 mcp = nv_rd32(dev, 0x660180 + (i * 0x20)); if (!(mcc & (1 << crtc)))
continue;
if (mcc & (1 << crtc))
disp->irq.dis = lookup_dcb(dev, i, mcc);
if (mcp & (1 << crtc)) { dcb = lookup_dcb(dev, i, mcc);
disp->irq.cfg = nv_rd32(dev, 0x660184 + (i * 0x20)); if (!dcb)
disp->irq.ena = lookup_dcb(dev, i, mcp); continue;
}
}
dcb = disp->irq.dis;
if (dcb)
nouveau_bios_run_display_table(dev, 0x0000, -1, dcb, crtc); nouveau_bios_run_display_table(dev, 0x0000, -1, dcb, crtc);
}
nv_wr32(dev, 0x6101d4, 0x00000000); nv_wr32(dev, 0x6101d4, 0x00000000);
nv_wr32(dev, 0x6109d4, 0x00000000); nv_wr32(dev, 0x6109d4, 0x00000000);
...@@ -1045,29 +1043,48 @@ nvd0_display_unk1_handler(struct drm_device *dev) ...@@ -1045,29 +1043,48 @@ nvd0_display_unk1_handler(struct drm_device *dev)
static void static void
nvd0_display_unk2_handler(struct drm_device *dev) nvd0_display_unk2_handler(struct drm_device *dev)
{ {
struct nvd0_display *disp = nvd0_display(dev);
struct dcb_entry *dcb; struct dcb_entry *dcb;
int crtc = disp->irq.crtc; u32 mask, crtc, pclk;
int pclk = disp->irq.pclk; u32 or, tmp;
int or; int i;
u32 tmp;
NV_INFO(dev, "PDISP: 2 0x%08x 0x%08x 0x%08x\n", nv_rd32(dev, 0x6101d0), mask = nv_rd32(dev, 0x6101d4);
nv_rd32(dev, 0x6101d4), nv_rd32(dev, 0x6109d4)); crtc = 0;
if (!mask) {
mask = nv_rd32(dev, 0x6109d4);
crtc = 1;
}
debug_irq(dev, 2);
for (i = 0; mask && i < 8; i++) {
u32 mcc = nv_rd32(dev, 0x640180 + (i * 0x20));
if (!(mcc & (1 << crtc)))
continue;
dcb = lookup_dcb(dev, i, mcc);
if (!dcb)
continue;
dcb = disp->irq.dis;
disp->irq.dis = NULL;
if (dcb)
nouveau_bios_run_display_table(dev, 0x0000, -2, dcb, crtc); nouveau_bios_run_display_table(dev, 0x0000, -2, dcb, crtc);
}
pclk = nv_rd32(dev, 0x660450 + (crtc * 0x300)) / 1000;
if (mask & 0x00010000) {
nv50_crtc_set_clock(dev, crtc, pclk); nv50_crtc_set_clock(dev, crtc, pclk);
}
for (i = 0; mask && i < 8; i++) {
u32 mcp = nv_rd32(dev, 0x660180 + (i * 0x20));
u32 cfg = nv_rd32(dev, 0x660184 + (i * 0x20));
if (!(mcp & (1 << crtc)))
continue;
dcb = disp->irq.ena; dcb = lookup_dcb(dev, i, mcp);
if (!dcb) if (!dcb)
goto ack; continue;
or = ffs(dcb->or) - 1; or = ffs(dcb->or) - 1;
nouveau_bios_run_display_table(dev, disp->irq.cfg, pclk, dcb, crtc); nouveau_bios_run_display_table(dev, cfg, pclk, dcb, crtc);
nv_wr32(dev, 0x612200 + (crtc * 0x800), 0x00000000); nv_wr32(dev, 0x612200 + (crtc * 0x800), 0x00000000);
switch (dcb->type) { switch (dcb->type) {
...@@ -1076,7 +1093,7 @@ nvd0_display_unk2_handler(struct drm_device *dev) ...@@ -1076,7 +1093,7 @@ nvd0_display_unk2_handler(struct drm_device *dev)
break; break;
case OUTPUT_TMDS: case OUTPUT_TMDS:
case OUTPUT_LVDS: case OUTPUT_LVDS:
if (disp->irq.cfg & 0x00000100) if (cfg & 0x00000100)
tmp = 0x00000101; tmp = 0x00000101;
else else
tmp = 0x00000000; tmp = 0x00000000;
...@@ -1087,7 +1104,9 @@ nvd0_display_unk2_handler(struct drm_device *dev) ...@@ -1087,7 +1104,9 @@ nvd0_display_unk2_handler(struct drm_device *dev)
break; break;
} }
ack: break;
}
nv_wr32(dev, 0x6101d4, 0x00000000); nv_wr32(dev, 0x6101d4, 0x00000000);
nv_wr32(dev, 0x6109d4, 0x00000000); nv_wr32(dev, 0x6109d4, 0x00000000);
nv_wr32(dev, 0x6101d0, 0x80000000); nv_wr32(dev, 0x6101d0, 0x80000000);
...@@ -1096,22 +1115,33 @@ nvd0_display_unk2_handler(struct drm_device *dev) ...@@ -1096,22 +1115,33 @@ nvd0_display_unk2_handler(struct drm_device *dev)
static void static void
nvd0_display_unk4_handler(struct drm_device *dev) nvd0_display_unk4_handler(struct drm_device *dev)
{ {
struct nvd0_display *disp = nvd0_display(dev);
struct dcb_entry *dcb; struct dcb_entry *dcb;
int crtc = disp->irq.crtc; u32 mask, crtc;
int pclk = disp->irq.pclk; int pclk, i;
NV_INFO(dev, "PDISP: 4 0x%08x 0x%08x 0x%08x\n", nv_rd32(dev, 0x6101d0), mask = nv_rd32(dev, 0x6101d4);
nv_rd32(dev, 0x6101d4), nv_rd32(dev, 0x6109d4)); crtc = 0;
if (!mask) {
mask = nv_rd32(dev, 0x6109d4);
crtc = 1;
}
debug_irq(dev, 4);
dcb = disp->irq.ena; pclk = nv_rd32(dev, 0x660450 + (crtc * 0x300)) / 1000;
disp->irq.ena = NULL;
for (i = 0; mask && i < 8; i++) {
u32 mcp = nv_rd32(dev, 0x660180 + (i * 0x20));
u32 cfg = nv_rd32(dev, 0x660184 + (i * 0x20));
if (!(mcp & (1 << crtc)))
continue;
dcb = lookup_dcb(dev, i, mcp);
if (!dcb) if (!dcb)
goto ack; continue;
nouveau_bios_run_display_table(dev, disp->irq.cfg, pclk, dcb, crtc); nouveau_bios_run_display_table(dev, cfg, -pclk, dcb, crtc);
}
ack:
nv_wr32(dev, 0x6101d4, 0x00000000); nv_wr32(dev, 0x6101d4, 0x00000000);
nv_wr32(dev, 0x6109d4, 0x00000000); nv_wr32(dev, 0x6109d4, 0x00000000);
nv_wr32(dev, 0x6101d0, 0x80000000); nv_wr32(dev, 0x6101d0, 0x80000000);
...@@ -1123,11 +1153,11 @@ nvd0_display_bh(unsigned long data) ...@@ -1123,11 +1153,11 @@ nvd0_display_bh(unsigned long data)
struct drm_device *dev = (struct drm_device *)data; struct drm_device *dev = (struct drm_device *)data;
struct nvd0_display *disp = nvd0_display(dev); struct nvd0_display *disp = nvd0_display(dev);
if (disp->irq.modeset & 0x00000001) if (disp->modeset & 0x00000001)
nvd0_display_unk1_handler(dev); nvd0_display_unk1_handler(dev);
if (disp->irq.modeset & 0x00000002) if (disp->modeset & 0x00000002)
nvd0_display_unk2_handler(dev); nvd0_display_unk2_handler(dev);
if (disp->irq.modeset & 0x00000004) if (disp->modeset & 0x00000004)
nvd0_display_unk4_handler(dev); nvd0_display_unk4_handler(dev);
} }
...@@ -1159,7 +1189,7 @@ nvd0_display_intr(struct drm_device *dev) ...@@ -1159,7 +1189,7 @@ nvd0_display_intr(struct drm_device *dev)
u32 stat = nv_rd32(dev, 0x6100ac); u32 stat = nv_rd32(dev, 0x6100ac);
if (stat & 0x00000007) { if (stat & 0x00000007) {
disp->irq.modeset = stat; disp->modeset = stat;
tasklet_schedule(&disp->tasklet); tasklet_schedule(&disp->tasklet);
nv_wr32(dev, 0x6100ac, (stat & 0x00000007)); nv_wr32(dev, 0x6100ac, (stat & 0x00000007));
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7