Commit ef26a5a6 authored by David Howells's avatar David Howells Committed by Rusty Russell

Guard check in module loader against integer overflow

The check:

	if (len < hdr->e_shoff + hdr->e_shnum * sizeof(Elf_Shdr))

may not work if there's an overflow in the right-hand side of the condition.
Signed-off-by: default avatarDavid Howells <dhowells@redhat.com>
Signed-off-by: default avatarRusty Russell <rusty@rustcorp.com.au>
parent 3c7ec94d
...@@ -2429,7 +2429,8 @@ static int copy_and_check(struct load_info *info, ...@@ -2429,7 +2429,8 @@ static int copy_and_check(struct load_info *info,
goto free_hdr; goto free_hdr;
} }
if (len < hdr->e_shoff + hdr->e_shnum * sizeof(Elf_Shdr)) { if (hdr->e_shoff >= len ||
hdr->e_shnum * sizeof(Elf_Shdr) > len - hdr->e_shoff) {
err = -ENOEXEC; err = -ENOEXEC;
goto free_hdr; goto free_hdr;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment