Commit eff65ee2 authored by Athira Rajeev's avatar Athira Rajeev Committed by Namhyung Kim

perf tests: Fix shellcheck warning in record_sideband.sh

Running shellcheck on record_sideband.sh throws below
warning:

	In tests/shell/record_sideband.sh line 25:
	  if ! perf record -o ${perfdata} -BN --no-bpf-event -C $1 true 2>&1 >/dev/null
	    ^--^ SC2069: To redirect stdout+stderr, 2>&1 must be last (or use '{ cmd > file; } 2>&1' to clarify).

This shows shellcheck warning SC2069 where the redirection
order needs to be fixed. Use "cmd > /dev/null 2>&1" to fix
the redirection of perf record output

Fixes: 23b97c7e ("perf test: Add test case for record sideband events")
Signed-off-by: default avatarAthira Rajeev <atrajeev@linux.vnet.ibm.com>
Reviewed-by: default avatarKajol Jain <kjain@linux.ibm.com>
Acked-by: default avatarNamhyung Kim <namhyung@kernel.org>
Cc: disgoel@linux.vnet.ibm.com
Link: https://lore.kernel.org/r/20231013073021.99794-3-atrajeev@linux.vnet.ibm.comSigned-off-by: default avatarNamhyung Kim <namhyung@kernel.org>
parent 47f5693c
...@@ -22,7 +22,7 @@ trap trap_cleanup EXIT TERM INT ...@@ -22,7 +22,7 @@ trap trap_cleanup EXIT TERM INT
can_cpu_wide() can_cpu_wide()
{ {
if ! perf record -o ${perfdata} -BN --no-bpf-event -C $1 true 2>&1 >/dev/null if ! perf record -o ${perfdata} -BN --no-bpf-event -C $1 true > /dev/null 2>&1
then then
echo "record sideband test [Skipped cannot record cpu$1]" echo "record sideband test [Skipped cannot record cpu$1]"
err=2 err=2
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment