Commit f14ae099 authored by Christian Engelmayer's avatar Christian Engelmayer Committed by Olof Johansson

platform/chrome: cros_ec: Fix possible leak in led_rgb_store()

Function led_rgb_store() contains some direct returns in error cases that
leak the already allocated cros_ec_command message structure. Make sure
that 'msg' is freed in all exit paths. Detected by Coverity CID 1309666.
Signed-off-by: default avatarChristian Engelmayer <cengelma@gmx.at>
Signed-off-by: default avatarOlof Johansson <olof@lixom.net>
parent 88dfb8b4
......@@ -252,7 +252,7 @@ static ssize_t led_rgb_store(struct device *dev, struct device_attribute *attr,
ret = sscanf(buf, "%i", &val[i++]);
if (ret == 0)
return -EINVAL;
goto exit;
if (i == 4) {
param = (struct ec_params_lightbar *)msg->data;
......@@ -268,17 +268,15 @@ static ssize_t led_rgb_store(struct device *dev, struct device_attribute *attr,
if ((j++ % 4) == 0) {
ret = lb_throttle();
if (ret)
return ret;
goto exit;
}
ret = cros_ec_cmd_xfer(ec->ec_dev, msg);
if (ret < 0)
goto exit;
if (msg->result != EC_RES_SUCCESS) {
ret = -EINVAL;
if (msg->result != EC_RES_SUCCESS)
goto exit;
}
i = 0;
ok = 1;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment