Commit f1ddfd95 authored by Jiri Slaby's avatar Jiri Slaby Committed by Linus Torvalds

ip2: init/deinit cleanup

Cleanup of module_init/exit:
- mostly whitespace
- remove empty functions
- replace c++ comments
- remove useless prints (module loaded, unloaded)
- mark the calls as __exit and __init
- use break; and return; to save some indent levels after it
- note resource leakage

It's still mess, but now it's readable.
Signed-off-by: default avatarJiri Slaby <jirislaby@gmail.com>
Signed-off-by: default avatarAlan Cox <alan@redhat.com>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 7ccd7020
...@@ -68,38 +68,6 @@ static DEFINE_RWLOCK(Dl_spinlock); ...@@ -68,38 +68,6 @@ static DEFINE_RWLOCK(Dl_spinlock);
// iiInitialize // iiInitialize
//======================================================= //=======================================================
//******************************************************************************
// Function: iiEllisInit()
// Parameters: None
//
// Returns: Nothing
//
// Description:
//
// This routine performs any required initialization of the iiEllis subsystem.
//
//******************************************************************************
static void
iiEllisInit(void)
{
}
//******************************************************************************
// Function: iiEllisCleanup()
// Parameters: None
//
// Returns: Nothing
//
// Description:
//
// This routine performs any required cleanup of the iiEllis subsystem.
//
//******************************************************************************
static void
iiEllisCleanup(void)
{
}
//****************************************************************************** //******************************************************************************
// Function: iiSetAddress(pB, address, delay) // Function: iiSetAddress(pB, address, delay)
// Parameters: pB - pointer to the board structure // Parameters: pB - pointer to the board structure
......
...@@ -511,7 +511,6 @@ typedef void (*delayFunc_t)(unsigned int); ...@@ -511,7 +511,6 @@ typedef void (*delayFunc_t)(unsigned int);
// //
// Initialization of a board & structure is in four (five!) parts: // Initialization of a board & structure is in four (five!) parts:
// //
// 0) iiEllisInit() - Initialize iiEllis subsystem.
// 1) iiSetAddress() - Define the board address & delay function for a board. // 1) iiSetAddress() - Define the board address & delay function for a board.
// 2) iiReset() - Reset the board (provided it exists) // 2) iiReset() - Reset the board (provided it exists)
// -- Note you may do this to several boards -- // -- Note you may do this to several boards --
...@@ -523,7 +522,6 @@ typedef void (*delayFunc_t)(unsigned int); ...@@ -523,7 +522,6 @@ typedef void (*delayFunc_t)(unsigned int);
// loadware. To change loadware, you must begin again with step 2, resetting // loadware. To change loadware, you must begin again with step 2, resetting
// the board again (step 1 not needed). // the board again (step 1 not needed).
static void iiEllisInit(void);
static int iiSetAddress(i2eBordStrPtr, int, delayFunc_t ); static int iiSetAddress(i2eBordStrPtr, int, delayFunc_t );
static int iiReset(i2eBordStrPtr); static int iiReset(i2eBordStrPtr);
static int iiResetDelay(i2eBordStrPtr); static int iiResetDelay(i2eBordStrPtr);
......
This diff is collapsed.
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment