Commit f3b8c0ca authored by Christian Engelmayer's avatar Christian Engelmayer Committed by Thomas Hellstrom

drm/vmwgfx: Fix uninitialized return in vmw_kms_helper_dirty()

Function vmw_kms_helper_dirty() uses the uninitialized variable ret as
return value. Make the result deterministic and directly return as the
variable is unused anyway. Detected by Coverity CID 1324255.
Signed-off-by: default avatarChristian Engelmayer <cengelma@gmx.at>
Reviewed-by: default avatarSinclair Yeh <syeh@vmware.com>
Reviewed-by: default avatarThomas Hellstrom <thellstrom@vmware.com>
parent 49558b47
...@@ -1685,7 +1685,6 @@ int vmw_kms_helper_dirty(struct vmw_private *dev_priv, ...@@ -1685,7 +1685,6 @@ int vmw_kms_helper_dirty(struct vmw_private *dev_priv,
struct drm_crtc *crtc; struct drm_crtc *crtc;
u32 num_units = 0; u32 num_units = 0;
u32 i, k; u32 i, k;
int ret;
dirty->dev_priv = dev_priv; dirty->dev_priv = dev_priv;
...@@ -1711,7 +1710,7 @@ int vmw_kms_helper_dirty(struct vmw_private *dev_priv, ...@@ -1711,7 +1710,7 @@ int vmw_kms_helper_dirty(struct vmw_private *dev_priv,
if (!dirty->cmd) { if (!dirty->cmd) {
DRM_ERROR("Couldn't reserve fifo space " DRM_ERROR("Couldn't reserve fifo space "
"for dirty blits.\n"); "for dirty blits.\n");
return ret; return -ENOMEM;
} }
memset(dirty->cmd, 0, dirty->fifo_reserve_size); memset(dirty->cmd, 0, dirty->fifo_reserve_size);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment