Commit f5d4c647 authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman Committed by Dmitry Torokhov

Input: applespi - no need to check return value of debugfs_create functions

When calling debugfs functions, there is no need to ever check the
return value.  The function can work or not, but the code logic should
never do something different based on this.
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
parent 042cc4c7
......@@ -1797,30 +1797,12 @@ static int applespi_probe(struct spi_device *spi)
/* set up debugfs entries for touchpad dimensions logging */
applespi->debugfs_root = debugfs_create_dir("applespi", NULL);
if (IS_ERR(applespi->debugfs_root)) {
if (PTR_ERR(applespi->debugfs_root) != -ENODEV)
dev_warn(&applespi->spi->dev,
"Error creating debugfs root entry (%ld)\n",
PTR_ERR(applespi->debugfs_root));
} else {
struct dentry *ret;
ret = debugfs_create_bool("enable_tp_dim", 0600,
applespi->debugfs_root,
debugfs_create_bool("enable_tp_dim", 0600, applespi->debugfs_root,
&applespi->debug_tp_dim);
if (IS_ERR(ret))
dev_dbg(&applespi->spi->dev,
"Error creating debugfs entry enable_tp_dim (%ld)\n",
PTR_ERR(ret));
ret = debugfs_create_file("tp_dim", 0400,
applespi->debugfs_root, applespi,
debugfs_create_file("tp_dim", 0400, applespi->debugfs_root, applespi,
&applespi_tp_dim_fops);
if (IS_ERR(ret))
dev_dbg(&applespi->spi->dev,
"Error creating debugfs entry tp_dim (%ld)\n",
PTR_ERR(ret));
}
return 0;
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment