Commit f6849d01 authored by Colin Ian King's avatar Colin Ian King Committed by David S. Miller

qlcnic: remove redundant zero check on retries counter

At the end of the do while loop the integer counter retries will
always be zero and so the subsequent check to see if it is zero
is always true and therefore redundant.  Remove the redundant check
and always return -EIO on this return path.  Also unbreak the literal
string in dev_err message to clean up a checkpatch warning.

Detected by CoverityScan, CID#744279 ("Logically dead code")
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent abd21a87
...@@ -592,13 +592,9 @@ qlcnic_receive_peg_ready(struct qlcnic_adapter *adapter) ...@@ -592,13 +592,9 @@ qlcnic_receive_peg_ready(struct qlcnic_adapter *adapter)
} while (--retries); } while (--retries);
if (!retries) { dev_err(&adapter->pdev->dev, "Receive Peg initialization not complete, state: 0x%x.\n",
dev_err(&adapter->pdev->dev, "Receive Peg initialization not " val);
"complete, state: 0x%x.\n", val);
return -EIO; return -EIO;
}
return 0;
} }
int int
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment