Commit f69e98a9 authored by Samson Tam's avatar Samson Tam Committed by Alex Deucher

drm/amd/display: Fix comments

[Why & how]
Fix format and typo of comments.
Acked-by: default avatarAlan Liu <HaoPing.Liu@amd.com>
Signed-off-by: default avatarSamson Tam <Samson.Tam@amd.com>
Tested-by: default avatarDaniel Wheeler <daniel.wheeler@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 85ee819f
...@@ -436,7 +436,6 @@ void dcn2_read_clocks_from_hw_dentist(struct clk_mgr *clk_mgr_base) ...@@ -436,7 +436,6 @@ void dcn2_read_clocks_from_hw_dentist(struct clk_mgr *clk_mgr_base)
clk_mgr_base->clks.dppclk_khz = (DENTIST_DIVIDER_RANGE_SCALE_FACTOR clk_mgr_base->clks.dppclk_khz = (DENTIST_DIVIDER_RANGE_SCALE_FACTOR
* clk_mgr->base.dentist_vco_freq_khz) / dpp_divider; * clk_mgr->base.dentist_vco_freq_khz) / dpp_divider;
} }
} }
void dcn2_get_clock(struct clk_mgr *clk_mgr, void dcn2_get_clock(struct clk_mgr *clk_mgr,
......
...@@ -1379,7 +1379,9 @@ bool dc_link_get_hpd_state(struct dc_link *dc_link) ...@@ -1379,7 +1379,9 @@ bool dc_link_get_hpd_state(struct dc_link *dc_link)
static enum hpd_source_id get_hpd_line(struct dc_link *link) static enum hpd_source_id get_hpd_line(struct dc_link *link)
{ {
struct gpio *hpd; struct gpio *hpd;
enum hpd_source_id hpd_id = HPD_SOURCEID_UNKNOWN; enum hpd_source_id hpd_id;
hpd_id = HPD_SOURCEID_UNKNOWN;
hpd = get_hpd_gpio(link->ctx->dc_bios, link->link_id, hpd = get_hpd_gpio(link->ctx->dc_bios, link->link_id,
link->ctx->gpio_service); link->ctx->gpio_service);
...@@ -1418,7 +1420,9 @@ static enum hpd_source_id get_hpd_line(struct dc_link *link) ...@@ -1418,7 +1420,9 @@ static enum hpd_source_id get_hpd_line(struct dc_link *link)
static enum channel_id get_ddc_line(struct dc_link *link) static enum channel_id get_ddc_line(struct dc_link *link)
{ {
struct ddc *ddc; struct ddc *ddc;
enum channel_id channel = CHANNEL_ID_UNKNOWN; enum channel_id channel;
channel = CHANNEL_ID_UNKNOWN;
ddc = dal_ddc_service_get_ddc_pin(link->ddc); ddc = dal_ddc_service_get_ddc_pin(link->ddc);
......
...@@ -150,7 +150,8 @@ static bool offset_to_id( ...@@ -150,7 +150,8 @@ static bool offset_to_id(
/* DDC */ /* DDC */
/* we don't care about the GPIO_ID for DDC /* we don't care about the GPIO_ID for DDC
* in DdcHandle it will use GPIO_ID_DDC_DATA/GPIO_ID_DDC_CLOCK * in DdcHandle it will use GPIO_ID_DDC_DATA/GPIO_ID_DDC_CLOCK
* directly in the create method */ * directly in the create method
*/
case REG(DC_GPIO_DDC1_A): case REG(DC_GPIO_DDC1_A):
*en = GPIO_DDC_LINE_DDC1; *en = GPIO_DDC_LINE_DDC1;
return true; return true;
...@@ -173,14 +174,16 @@ static bool offset_to_id( ...@@ -173,14 +174,16 @@ static bool offset_to_id(
*en = GPIO_DDC_LINE_DDC_VGA; *en = GPIO_DDC_LINE_DDC_VGA;
return true; return true;
// case REG(DC_GPIO_I2CPAD_A): not exit /*
// case REG(DC_GPIO_PWRSEQ_A): * case REG(DC_GPIO_I2CPAD_A): not exit
// case REG(DC_GPIO_PAD_STRENGTH_1): * case REG(DC_GPIO_PWRSEQ_A):
// case REG(DC_GPIO_PAD_STRENGTH_2): * case REG(DC_GPIO_PAD_STRENGTH_1):
// case REG(DC_GPIO_DEBUG): * case REG(DC_GPIO_PAD_STRENGTH_2):
* case REG(DC_GPIO_DEBUG):
*/
/* UNEXPECTED */ /* UNEXPECTED */
default: default:
// case REG(DC_GPIO_SYNCA_A): not exist /* case REG(DC_GPIO_SYNCA_A): not exist */
ASSERT_CRITICAL(false); ASSERT_CRITICAL(false);
return false; return false;
} }
......
...@@ -153,7 +153,8 @@ static bool offset_to_id( ...@@ -153,7 +153,8 @@ static bool offset_to_id(
/* DDC */ /* DDC */
/* we don't care about the GPIO_ID for DDC /* we don't care about the GPIO_ID for DDC
* in DdcHandle it will use GPIO_ID_DDC_DATA/GPIO_ID_DDC_CLOCK * in DdcHandle it will use GPIO_ID_DDC_DATA/GPIO_ID_DDC_CLOCK
* directly in the create method */ * directly in the create method
*/
case REG(DC_GPIO_DDC1_A): case REG(DC_GPIO_DDC1_A):
*en = GPIO_DDC_LINE_DDC1; *en = GPIO_DDC_LINE_DDC1;
return true; return true;
...@@ -173,14 +174,16 @@ static bool offset_to_id( ...@@ -173,14 +174,16 @@ static bool offset_to_id(
*en = GPIO_DDC_LINE_DDC_VGA; *en = GPIO_DDC_LINE_DDC_VGA;
return true; return true;
// case REG(DC_GPIO_I2CPAD_A): not exit /*
// case REG(DC_GPIO_PWRSEQ_A): * case REG(DC_GPIO_I2CPAD_A): not exit
// case REG(DC_GPIO_PAD_STRENGTH_1): * case REG(DC_GPIO_PWRSEQ_A):
// case REG(DC_GPIO_PAD_STRENGTH_2): * case REG(DC_GPIO_PAD_STRENGTH_1):
// case REG(DC_GPIO_DEBUG): * case REG(DC_GPIO_PAD_STRENGTH_2):
* case REG(DC_GPIO_DEBUG):
*/
/* UNEXPECTED */ /* UNEXPECTED */
default: default:
// case REG(DC_GPIO_SYNCA_A): not exist /* case REG(DC_GPIO_SYNCA_A): not exista */
#ifdef PALLADIUM_SUPPORTED #ifdef PALLADIUM_SUPPORTED
*id = GPIO_ID_HPD; *id = GPIO_ID_HPD;
*en = GPIO_DDC_LINE_DDC1; *en = GPIO_DDC_LINE_DDC1;
......
...@@ -155,7 +155,8 @@ static bool offset_to_id( ...@@ -155,7 +155,8 @@ static bool offset_to_id(
/* DDC */ /* DDC */
/* we don't care about the GPIO_ID for DDC /* we don't care about the GPIO_ID for DDC
* in DdcHandle it will use GPIO_ID_DDC_DATA/GPIO_ID_DDC_CLOCK * in DdcHandle it will use GPIO_ID_DDC_DATA/GPIO_ID_DDC_CLOCK
* directly in the create method */ * directly in the create method
*/
case REG(DC_GPIO_DDC1_A): case REG(DC_GPIO_DDC1_A):
*en = GPIO_DDC_LINE_DDC1; *en = GPIO_DDC_LINE_DDC1;
return true; return true;
...@@ -178,14 +179,16 @@ static bool offset_to_id( ...@@ -178,14 +179,16 @@ static bool offset_to_id(
*en = GPIO_DDC_LINE_DDC_VGA; *en = GPIO_DDC_LINE_DDC_VGA;
return true; return true;
// case REG(DC_GPIO_I2CPAD_A): not exit /*
// case REG(DC_GPIO_PWRSEQ_A): * case REG(DC_GPIO_I2CPAD_A): not exit
// case REG(DC_GPIO_PAD_STRENGTH_1): * case REG(DC_GPIO_PWRSEQ_A):
// case REG(DC_GPIO_PAD_STRENGTH_2): * case REG(DC_GPIO_PAD_STRENGTH_1):
// case REG(DC_GPIO_DEBUG): * case REG(DC_GPIO_PAD_STRENGTH_2):
* case REG(DC_GPIO_DEBUG):
*/
/* UNEXPECTED */ /* UNEXPECTED */
default: default:
// case REG(DC_GPIO_SYNCA_A): not exist /* case REG(DC_GPIO_SYNCA_A): not exist */
ASSERT_CRITICAL(false); ASSERT_CRITICAL(false);
return false; return false;
} }
...@@ -369,7 +372,7 @@ static const struct hw_translate_funcs funcs = { ...@@ -369,7 +372,7 @@ static const struct hw_translate_funcs funcs = {
}; };
/* /*
* dal_hw_translate_dcn10_init * dal_hw_translate_dcn30_init
* *
* @brief * @brief
* Initialize Hw translate function pointers. * Initialize Hw translate function pointers.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment