Commit f744d9a4 authored by Deepak R Varma's avatar Deepak R Varma Committed by Mauro Carvalho Chehab

media: staging/intel-ipu3: Simplify single goto jump

On successful node setup, the code jumps to a cleanup label to perform
nodes cleanup. This only call to cleanup using goto label can be
included in the for / if blocks to make it look more associated.
Signed-off-by: default avatarDeepak R Varma <mh12gx2825@gmail.com>
Reviewed-by: default avatarStefano Brivio <sbrivio@redhat.com>
Signed-off-by: default avatarSakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
parent ce7d96a4
...@@ -1300,19 +1300,17 @@ static void imgu_v4l2_nodes_cleanup_pipe(struct imgu_device *imgu, ...@@ -1300,19 +1300,17 @@ static void imgu_v4l2_nodes_cleanup_pipe(struct imgu_device *imgu,
static int imgu_v4l2_nodes_setup_pipe(struct imgu_device *imgu, int pipe) static int imgu_v4l2_nodes_setup_pipe(struct imgu_device *imgu, int pipe)
{ {
int i, r; int i;
for (i = 0; i < IMGU_NODE_NUM; i++) { for (i = 0; i < IMGU_NODE_NUM; i++) {
r = imgu_v4l2_node_setup(imgu, pipe, i); int r = imgu_v4l2_node_setup(imgu, pipe, i);
if (r)
goto cleanup;
}
return 0;
cleanup: if (r) {
imgu_v4l2_nodes_cleanup_pipe(imgu, pipe, i); imgu_v4l2_nodes_cleanup_pipe(imgu, pipe, i);
return r; return r;
}
}
return 0;
} }
static void imgu_v4l2_subdev_cleanup(struct imgu_device *imgu, unsigned int i) static void imgu_v4l2_subdev_cleanup(struct imgu_device *imgu, unsigned int i)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment