Commit f8c0d7b1 authored by YueHaibing's avatar YueHaibing Committed by Jens Axboe

blk-iolatency: remove set but not used variables 'changed' and 'blkiolat'

Fixes gcc '-Wunused-but-set-variable' warning:

block/blk-iolatency.c: In function 'scale_change':
block/blk-iolatency.c:301:7: warning:
 variable 'changed' set but not used [-Wunused-but-set-variable]

block/blk-iolatency.c: In function 'iolatency_set_limit':
block/blk-iolatency.c:765:24: warning:
 variable 'blkiolat' set but not used [-Wunused-but-set-variable]
Signed-off-by: default avatarYueHaibing <yuehaibing@huawei.com>
Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 798ef9e7
...@@ -298,7 +298,6 @@ static void scale_change(struct iolatency_grp *iolat, bool up) ...@@ -298,7 +298,6 @@ static void scale_change(struct iolatency_grp *iolat, bool up)
unsigned long qd = blk_queue_depth(iolat->blkiolat->rqos.q); unsigned long qd = blk_queue_depth(iolat->blkiolat->rqos.q);
unsigned long scale = scale_amount(qd, up); unsigned long scale = scale_amount(qd, up);
unsigned long old = iolat->rq_depth.max_depth; unsigned long old = iolat->rq_depth.max_depth;
bool changed = false;
if (old > qd) if (old > qd)
old = qd; old = qd;
...@@ -308,7 +307,6 @@ static void scale_change(struct iolatency_grp *iolat, bool up) ...@@ -308,7 +307,6 @@ static void scale_change(struct iolatency_grp *iolat, bool up)
return; return;
if (old < qd) { if (old < qd) {
changed = true;
old += scale; old += scale;
old = min(old, qd); old = min(old, qd);
iolat->rq_depth.max_depth = old; iolat->rq_depth.max_depth = old;
...@@ -316,7 +314,6 @@ static void scale_change(struct iolatency_grp *iolat, bool up) ...@@ -316,7 +314,6 @@ static void scale_change(struct iolatency_grp *iolat, bool up)
} }
} else if (old > 1) { } else if (old > 1) {
old >>= 1; old >>= 1;
changed = true;
iolat->rq_depth.max_depth = max(old, 1UL); iolat->rq_depth.max_depth = max(old, 1UL);
} }
} }
...@@ -761,7 +758,6 @@ static ssize_t iolatency_set_limit(struct kernfs_open_file *of, char *buf, ...@@ -761,7 +758,6 @@ static ssize_t iolatency_set_limit(struct kernfs_open_file *of, char *buf,
{ {
struct blkcg *blkcg = css_to_blkcg(of_css(of)); struct blkcg *blkcg = css_to_blkcg(of_css(of));
struct blkcg_gq *blkg; struct blkcg_gq *blkg;
struct blk_iolatency *blkiolat;
struct blkg_conf_ctx ctx; struct blkg_conf_ctx ctx;
struct iolatency_grp *iolat; struct iolatency_grp *iolat;
char *p, *tok; char *p, *tok;
...@@ -774,7 +770,6 @@ static ssize_t iolatency_set_limit(struct kernfs_open_file *of, char *buf, ...@@ -774,7 +770,6 @@ static ssize_t iolatency_set_limit(struct kernfs_open_file *of, char *buf,
return ret; return ret;
iolat = blkg_to_lat(ctx.blkg); iolat = blkg_to_lat(ctx.blkg);
blkiolat = iolat->blkiolat;
p = ctx.body; p = ctx.body;
ret = -EINVAL; ret = -EINVAL;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment