Commit fae54158 authored by Mathieu Poirier's avatar Mathieu Poirier Committed by Greg Kroah-Hartman

coresight: coresight_unregister() function cleanup

In its current form the code never frees csdev->refcnt allocated
in coresight_register().  There is also a problem with csdev->conns
that is freed before device_unregister() rather than in the device
release function.

This patch addresses both issues by moving kfree(csdev->conns) to
coresight_device_release() and freeing csdev->refcnt, also in
the same function.
Reported-by: default avatarRabin Vincent <rabin@rab.in>
Signed-off-by: default avatarMathieu Poirier <mathieu.poirier@linaro.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent a9ddc71f
...@@ -481,6 +481,8 @@ static void coresight_device_release(struct device *dev) ...@@ -481,6 +481,8 @@ static void coresight_device_release(struct device *dev)
{ {
struct coresight_device *csdev = to_coresight_device(dev); struct coresight_device *csdev = to_coresight_device(dev);
kfree(csdev->conns);
kfree(csdev->refcnt);
kfree(csdev); kfree(csdev);
} }
...@@ -713,7 +715,6 @@ EXPORT_SYMBOL_GPL(coresight_register); ...@@ -713,7 +715,6 @@ EXPORT_SYMBOL_GPL(coresight_register);
void coresight_unregister(struct coresight_device *csdev) void coresight_unregister(struct coresight_device *csdev)
{ {
kfree(csdev->conns);
device_unregister(&csdev->dev); device_unregister(&csdev->dev);
} }
EXPORT_SYMBOL_GPL(coresight_unregister); EXPORT_SYMBOL_GPL(coresight_unregister);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment