Commit fb27e70f authored by Ben Hutchings's avatar Ben Hutchings Committed by Masahiro Yamada

modpost: Fix processing of CRCs on 32-bit build machines

modpost now reads CRCs from .*.cmd files, parsing them using strtol().
This is inconsistent with its parsing of Module.symvers and with their
definition as *unsigned* 32-bit values.

strtol() clamps values to [LONG_MIN, LONG_MAX], and when building on a
32-bit system this changes all CRCs >= 0x80000000 to be 0x7fffffff.

Change extract_crcs_for_object() to use strtoul() instead.

Cc: stable@vger.kernel.org
Fixes: f292d875 ("modpost: extract symbol versions from *.cmd files")
Signed-off-by: default avatarBen Hutchings <ben@decadent.org.uk>
Signed-off-by: default avatarMasahiro Yamada <masahiroy@kernel.org>
parent 1073c15f
...@@ -1733,7 +1733,7 @@ static void extract_crcs_for_object(const char *object, struct module *mod) ...@@ -1733,7 +1733,7 @@ static void extract_crcs_for_object(const char *object, struct module *mod)
if (!isdigit(*p)) if (!isdigit(*p))
continue; /* skip this line */ continue; /* skip this line */
crc = strtol(p, &p, 0); crc = strtoul(p, &p, 0);
if (*p != '\n') if (*p != '\n')
continue; /* skip this line */ continue; /* skip this line */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment