Commit fbefc5e7 authored by Dmitry Torokhov's avatar Dmitry Torokhov

Input: max77693-haptic - fix potential overflow

Expression haptic->pwm_dev->period * haptic->magnitude is of type
'unsigned int' and may overflow. We need to convert one of the operands
to u64 before multiplying, instead of casting result (potentially
overflown) to u64.

Reported by Coverity: CID 1248753

Acked-by : Jaewon Kim <jaewon02.kim@samsung.com>
Reviewed-by: default avatarChanwoo Choi <cw00.choi@samsung.com>
Signed-off-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
parent 185af4d6
...@@ -194,7 +194,7 @@ static int max77693_haptic_play_effect(struct input_dev *dev, void *data, ...@@ -194,7 +194,7 @@ static int max77693_haptic_play_effect(struct input_dev *dev, void *data,
struct ff_effect *effect) struct ff_effect *effect)
{ {
struct max77693_haptic *haptic = input_get_drvdata(dev); struct max77693_haptic *haptic = input_get_drvdata(dev);
uint64_t period_mag_multi; u64 period_mag_multi;
haptic->magnitude = effect->u.rumble.strong_magnitude; haptic->magnitude = effect->u.rumble.strong_magnitude;
if (!haptic->magnitude) if (!haptic->magnitude)
...@@ -205,8 +205,7 @@ static int max77693_haptic_play_effect(struct input_dev *dev, void *data, ...@@ -205,8 +205,7 @@ static int max77693_haptic_play_effect(struct input_dev *dev, void *data,
* The formula to convert magnitude to pwm_duty as follows: * The formula to convert magnitude to pwm_duty as follows:
* - pwm_duty = (magnitude * pwm_period) / MAX_MAGNITUDE(0xFFFF) * - pwm_duty = (magnitude * pwm_period) / MAX_MAGNITUDE(0xFFFF)
*/ */
period_mag_multi = (int64_t)(haptic->pwm_dev->period * period_mag_multi = (u64)haptic->pwm_dev->period * haptic->magnitude;
haptic->magnitude);
haptic->pwm_duty = (unsigned int)(period_mag_multi >> haptic->pwm_duty = (unsigned int)(period_mag_multi >>
MAX_MAGNITUDE_SHIFT); MAX_MAGNITUDE_SHIFT);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment