Commit fc21ed8f authored by Haowen Bai's avatar Haowen Bai Committed by Michael Ellerman

macintosh/macio-adb: Fix warning comparing pointer to 0

Avoid pointer type value compared with 0 to make code clear.
Signed-off-by: default avatarHaowen Bai <baihaowen@meizu.com>
Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/1647509089-4280-1-git-send-email-baihaowen@meizu.com
parent a823307b
...@@ -100,7 +100,7 @@ int macio_init(void) ...@@ -100,7 +100,7 @@ int macio_init(void)
unsigned int irq; unsigned int irq;
adbs = of_find_compatible_node(NULL, "adb", "chrp,adb0"); adbs = of_find_compatible_node(NULL, "adb", "chrp,adb0");
if (adbs == 0) if (!adbs)
return -ENXIO; return -ENXIO;
if (of_address_to_resource(adbs, 0, &r)) { if (of_address_to_resource(adbs, 0, &r)) {
...@@ -183,7 +183,7 @@ static int macio_send_request(struct adb_request *req, int sync) ...@@ -183,7 +183,7 @@ static int macio_send_request(struct adb_request *req, int sync)
req->reply_len = 0; req->reply_len = 0;
spin_lock_irqsave(&macio_lock, flags); spin_lock_irqsave(&macio_lock, flags);
if (current_req != 0) { if (current_req) {
last_req->next = req; last_req->next = req;
last_req = req; last_req = req;
} else { } else {
...@@ -213,7 +213,8 @@ static irqreturn_t macio_adb_interrupt(int irq, void *arg) ...@@ -213,7 +213,8 @@ static irqreturn_t macio_adb_interrupt(int irq, void *arg)
spin_lock(&macio_lock); spin_lock(&macio_lock);
if (in_8(&adb->intr.r) & TAG) { if (in_8(&adb->intr.r) & TAG) {
handled = 1; handled = 1;
if ((req = current_req) != 0) { req = current_req;
if (req) {
/* put the current request in */ /* put the current request in */
for (i = 0; i < req->nbytes; ++i) for (i = 0; i < req->nbytes; ++i)
out_8(&adb->data[i].r, req->data[i]); out_8(&adb->data[i].r, req->data[i]);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment