Commit fce85157 authored by Yan, Zheng's avatar Yan, Zheng Committed by Ilya Dryomov

ceph: fix NULL dereference in ceph_queue_cap_snap()

old_snapc->seq is used in dout(...)
Signed-off-by: default avatarYan, Zheng <zyan@redhat.com>
parent 9a5530c6
...@@ -551,7 +551,6 @@ void ceph_queue_cap_snap(struct ceph_inode_info *ci) ...@@ -551,7 +551,6 @@ void ceph_queue_cap_snap(struct ceph_inode_info *ci)
ci->i_wrbuffer_ref_head = 0; ci->i_wrbuffer_ref_head = 0;
capsnap->context = old_snapc; capsnap->context = old_snapc;
list_add_tail(&capsnap->ci_item, &ci->i_cap_snaps); list_add_tail(&capsnap->ci_item, &ci->i_cap_snaps);
old_snapc = NULL;
if (used & CEPH_CAP_FILE_WR) { if (used & CEPH_CAP_FILE_WR) {
dout("queue_cap_snap %p cap_snap %p snapc %p" dout("queue_cap_snap %p cap_snap %p snapc %p"
...@@ -563,6 +562,7 @@ void ceph_queue_cap_snap(struct ceph_inode_info *ci) ...@@ -563,6 +562,7 @@ void ceph_queue_cap_snap(struct ceph_inode_info *ci)
__ceph_finish_cap_snap(ci, capsnap); __ceph_finish_cap_snap(ci, capsnap);
} }
capsnap = NULL; capsnap = NULL;
old_snapc = NULL;
update_snapc: update_snapc:
if (ci->i_head_snapc) { if (ci->i_head_snapc) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment