Commit fcf23238 authored by Paul Cercueil's avatar Paul Cercueil

drm: shmobile: Remove #ifdef guards for PM related functions

Use the DEFINE_SIMPLE_DEV_PM_OPS() and pm_sleep_ptr() macros to handle
the .suspend/.resume callbacks.

These macros allow the suspend and resume functions to be automatically
dropped by the compiler when CONFIG_SUSPEND is disabled, without having
to use #ifdef guards.

This has the advantage of always compiling these functions in,
independently of any Kconfig option. Thanks to that, bugs and other
regressions are subsequently easier to catch.
Signed-off-by: default avatarPaul Cercueil <paul@crapouillou.net>
Reviewed-by: default avatarKieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Reviewed-by: default avatarLaurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20221129191942.138244-6-paul@crapouillou.net
parent c3ad24ac
...@@ -143,7 +143,6 @@ static const struct drm_driver shmob_drm_driver = { ...@@ -143,7 +143,6 @@ static const struct drm_driver shmob_drm_driver = {
* Power management * Power management
*/ */
#ifdef CONFIG_PM_SLEEP
static int shmob_drm_pm_suspend(struct device *dev) static int shmob_drm_pm_suspend(struct device *dev)
{ {
struct shmob_drm_device *sdev = dev_get_drvdata(dev); struct shmob_drm_device *sdev = dev_get_drvdata(dev);
...@@ -165,11 +164,9 @@ static int shmob_drm_pm_resume(struct device *dev) ...@@ -165,11 +164,9 @@ static int shmob_drm_pm_resume(struct device *dev)
drm_kms_helper_poll_enable(sdev->ddev); drm_kms_helper_poll_enable(sdev->ddev);
return 0; return 0;
} }
#endif
static const struct dev_pm_ops shmob_drm_pm_ops = { static DEFINE_SIMPLE_DEV_PM_OPS(shmob_drm_pm_ops,
SET_SYSTEM_SLEEP_PM_OPS(shmob_drm_pm_suspend, shmob_drm_pm_resume) shmob_drm_pm_suspend, shmob_drm_pm_resume);
};
/* ----------------------------------------------------------------------------- /* -----------------------------------------------------------------------------
* Platform driver * Platform driver
...@@ -292,7 +289,7 @@ static struct platform_driver shmob_drm_platform_driver = { ...@@ -292,7 +289,7 @@ static struct platform_driver shmob_drm_platform_driver = {
.remove = shmob_drm_remove, .remove = shmob_drm_remove,
.driver = { .driver = {
.name = "shmob-drm", .name = "shmob-drm",
.pm = &shmob_drm_pm_ops, .pm = pm_sleep_ptr(&shmob_drm_pm_ops),
}, },
}; };
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment