Commit fdd8218d authored by Dan Carpenter's avatar Dan Carpenter Committed by Takashi Iwai

ALSA: line6: fix a crash in line6_hwdep_write()

The error checking here is messed up so we could end up dereferencing
-EFAULT.

Fixes: a16039cb ('ALSA: line6: Add hwdep interface to access the POD control messages')
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: default avatarTakashi Sakamoto <o-takashi@sakamocchi.jp>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 30c07022
...@@ -604,8 +604,8 @@ line6_hwdep_write(struct snd_hwdep *hwdep, const char __user *data, long count, ...@@ -604,8 +604,8 @@ line6_hwdep_write(struct snd_hwdep *hwdep, const char __user *data, long count,
} }
data_copy = memdup_user(data, count); data_copy = memdup_user(data, count);
if (IS_ERR(ERR_PTR)) if (IS_ERR(data_copy))
return -ENOMEM; return PTR_ERR(data_copy);
rv = line6_send_raw_message(line6, data_copy, count); rv = line6_send_raw_message(line6, data_copy, count);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment