Commit fe513c2e authored by Thomas Gleixner's avatar Thomas Gleixner Committed by Peter Zijlstra

static_call: Replace pointless WARN_ON() in static_call_module_notify()

static_call_module_notify() triggers a WARN_ON(), when memory allocation
fails in __static_call_add_module().

That's not really justified, because the failure case must be correctly
handled by the well known call chain and the error code is passed
through to the initiating userspace application.

A memory allocation fail is not a fatal problem, but the WARN_ON() takes
the machine out when panic_on_warn is set.

Replace it with a pr_warn().

Fixes: 9183c3f9 ("static_call: Add inline static call infrastructure")
Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
Signed-off-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lkml.kernel.org/r/8734mf7pmb.ffs@tglx
parent 4b30051c
...@@ -453,7 +453,7 @@ static int static_call_module_notify(struct notifier_block *nb, ...@@ -453,7 +453,7 @@ static int static_call_module_notify(struct notifier_block *nb,
case MODULE_STATE_COMING: case MODULE_STATE_COMING:
ret = static_call_add_module(mod); ret = static_call_add_module(mod);
if (ret) { if (ret) {
WARN(1, "Failed to allocate memory for static calls"); pr_warn("Failed to allocate memory for static calls\n");
static_call_del_module(mod); static_call_del_module(mod);
} }
break; break;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment