Commit fe9f57f2 authored by Ingo Molnar's avatar Ingo Molnar

tracing: add run-time field descriptions for event filtering, kfree fix

Impact: fix potential kfree of random data in (rare) failure path

Zero-initialize the field structure.
Reported-by: default avatarFrederic Weisbecker <fweisbec@gmail.com>
Cc: Tom Zanussi <tzanussi@gmail.com>
LKML-Reference: <1237710639.7703.46.camel@charm-linux>
Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
parent cfb180f3
...@@ -24,26 +24,31 @@ int trace_define_field(struct ftrace_event_call *call, char *type, ...@@ -24,26 +24,31 @@ int trace_define_field(struct ftrace_event_call *call, char *type,
{ {
struct ftrace_event_field *field; struct ftrace_event_field *field;
field = kmalloc(sizeof(*field), GFP_KERNEL); field = kzalloc(sizeof(*field), GFP_KERNEL);
if (!field) if (!field)
goto err; goto err;
field->name = kstrdup(name, GFP_KERNEL); field->name = kstrdup(name, GFP_KERNEL);
if (!field->name) if (!field->name)
goto err; goto err;
field->type = kstrdup(type, GFP_KERNEL); field->type = kstrdup(type, GFP_KERNEL);
if (!field->type) if (!field->type)
goto err; goto err;
field->offset = offset; field->offset = offset;
field->size = size; field->size = size;
list_add(&field->link, &call->fields); list_add(&field->link, &call->fields);
return 0; return 0;
err: err:
if (field) { if (field) {
kfree(field->name); kfree(field->name);
kfree(field->type); kfree(field->type);
} }
kfree(field); kfree(field);
return -ENOMEM; return -ENOMEM;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment