Commit ff48bc44 authored by Lee Jones's avatar Lee Jones Committed by Mika Westerberg

thunderbolt: eeprom: Demote non-conformant kernel-doc headers to standard comment blocks

Fixes the following W=1 kernel build warning(s):

 drivers/thunderbolt/eeprom.c:19: warning: Function parameter or member 'sw' not described in 'tb_eeprom_ctl_write'
 drivers/thunderbolt/eeprom.c:19: warning: Function parameter or member 'ctl' not described in 'tb_eeprom_ctl_write'
 drivers/thunderbolt/eeprom.c:27: warning: Function parameter or member 'sw' not described in 'tb_eeprom_ctl_read'
 drivers/thunderbolt/eeprom.c:27: warning: Function parameter or member 'ctl' not described in 'tb_eeprom_ctl_read'
 drivers/thunderbolt/eeprom.c:27: warning: expecting prototype for tb_eeprom_ctl_write(). Prototype was for tb_eeprom_ctl_read() instead
 drivers/thunderbolt/eeprom.c:43: warning: Function parameter or member 'sw' not described in 'tb_eeprom_active'
 drivers/thunderbolt/eeprom.c:43: warning: Function parameter or member 'enable' not described in 'tb_eeprom_active'
 drivers/thunderbolt/eeprom.c:73: warning: Function parameter or member 'sw' not described in 'tb_eeprom_transfer'
 drivers/thunderbolt/eeprom.c:73: warning: Function parameter or member 'ctl' not described in 'tb_eeprom_transfer'
 drivers/thunderbolt/eeprom.c:73: warning: Function parameter or member 'direction' not described in 'tb_eeprom_transfer'
 drivers/thunderbolt/eeprom.c:97: warning: Function parameter or member 'sw' not described in 'tb_eeprom_out'
 drivers/thunderbolt/eeprom.c:97: warning: Function parameter or member 'val' not described in 'tb_eeprom_out'
 drivers/thunderbolt/eeprom.c:117: warning: Function parameter or member 'sw' not described in 'tb_eeprom_in'
 drivers/thunderbolt/eeprom.c:117: warning: Function parameter or member 'val' not described in 'tb_eeprom_in'
 drivers/thunderbolt/eeprom.c:138: warning: Function parameter or member 'sw' not described in 'tb_eeprom_get_drom_offset'
 drivers/thunderbolt/eeprom.c:138: warning: Function parameter or member 'offset' not described in 'tb_eeprom_get_drom_offset'
 drivers/thunderbolt/eeprom.c:170: warning: Function parameter or member 'sw' not described in 'tb_eeprom_read_n'
 drivers/thunderbolt/eeprom.c:170: warning: Function parameter or member 'offset' not described in 'tb_eeprom_read_n'
 drivers/thunderbolt/eeprom.c:170: warning: Function parameter or member 'val' not described in 'tb_eeprom_read_n'
 drivers/thunderbolt/eeprom.c:170: warning: Function parameter or member 'count' not described in 'tb_eeprom_read_n'
 drivers/thunderbolt/eeprom.c:383: warning: Function parameter or member 'sw' not described in 'tb_drom_parse_entries'
 drivers/thunderbolt/eeprom.c:417: warning: Function parameter or member 'sw' not described in 'tb_drom_copy_efi'
 drivers/thunderbolt/eeprom.c:417: warning: Function parameter or member 'size' not described in 'tb_drom_copy_efi'

Cc: Andreas Noever <andreas.noever@gmail.com>
Cc: Michael Jamet <michael.jamet@intel.com>
Cc: Yehezkel Bernat <YehezkelShB@gmail.com>
Cc: linux-usb@vger.kernel.org
Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
[ mw: Demote only static functions ]
Signed-off-by: default avatarMika Westerberg <mika.westerberg@linux.intel.com>
parent aa608253
...@@ -12,7 +12,7 @@ ...@@ -12,7 +12,7 @@
#include <linux/slab.h> #include <linux/slab.h>
#include "tb.h" #include "tb.h"
/** /*
* tb_eeprom_ctl_write() - write control word * tb_eeprom_ctl_write() - write control word
*/ */
static int tb_eeprom_ctl_write(struct tb_switch *sw, struct tb_eeprom_ctl *ctl) static int tb_eeprom_ctl_write(struct tb_switch *sw, struct tb_eeprom_ctl *ctl)
...@@ -20,7 +20,7 @@ static int tb_eeprom_ctl_write(struct tb_switch *sw, struct tb_eeprom_ctl *ctl) ...@@ -20,7 +20,7 @@ static int tb_eeprom_ctl_write(struct tb_switch *sw, struct tb_eeprom_ctl *ctl)
return tb_sw_write(sw, ctl, TB_CFG_SWITCH, sw->cap_plug_events + 4, 1); return tb_sw_write(sw, ctl, TB_CFG_SWITCH, sw->cap_plug_events + 4, 1);
} }
/** /*
* tb_eeprom_ctl_write() - read control word * tb_eeprom_ctl_write() - read control word
*/ */
static int tb_eeprom_ctl_read(struct tb_switch *sw, struct tb_eeprom_ctl *ctl) static int tb_eeprom_ctl_read(struct tb_switch *sw, struct tb_eeprom_ctl *ctl)
...@@ -33,7 +33,7 @@ enum tb_eeprom_transfer { ...@@ -33,7 +33,7 @@ enum tb_eeprom_transfer {
TB_EEPROM_OUT, TB_EEPROM_OUT,
}; };
/** /*
* tb_eeprom_active - enable rom access * tb_eeprom_active - enable rom access
* *
* WARNING: Always disable access after usage. Otherwise the controller will * WARNING: Always disable access after usage. Otherwise the controller will
...@@ -62,7 +62,7 @@ static int tb_eeprom_active(struct tb_switch *sw, bool enable) ...@@ -62,7 +62,7 @@ static int tb_eeprom_active(struct tb_switch *sw, bool enable)
} }
} }
/** /*
* tb_eeprom_transfer - transfer one bit * tb_eeprom_transfer - transfer one bit
* *
* If TB_EEPROM_IN is passed, then the bit can be retrieved from ctl->data_in. * If TB_EEPROM_IN is passed, then the bit can be retrieved from ctl->data_in.
...@@ -90,7 +90,7 @@ static int tb_eeprom_transfer(struct tb_switch *sw, struct tb_eeprom_ctl *ctl, ...@@ -90,7 +90,7 @@ static int tb_eeprom_transfer(struct tb_switch *sw, struct tb_eeprom_ctl *ctl,
return tb_eeprom_ctl_write(sw, ctl); return tb_eeprom_ctl_write(sw, ctl);
} }
/** /*
* tb_eeprom_out - write one byte to the bus * tb_eeprom_out - write one byte to the bus
*/ */
static int tb_eeprom_out(struct tb_switch *sw, u8 val) static int tb_eeprom_out(struct tb_switch *sw, u8 val)
...@@ -110,7 +110,7 @@ static int tb_eeprom_out(struct tb_switch *sw, u8 val) ...@@ -110,7 +110,7 @@ static int tb_eeprom_out(struct tb_switch *sw, u8 val)
return 0; return 0;
} }
/** /*
* tb_eeprom_in - read one byte from the bus * tb_eeprom_in - read one byte from the bus
*/ */
static int tb_eeprom_in(struct tb_switch *sw, u8 *val) static int tb_eeprom_in(struct tb_switch *sw, u8 *val)
...@@ -131,7 +131,7 @@ static int tb_eeprom_in(struct tb_switch *sw, u8 *val) ...@@ -131,7 +131,7 @@ static int tb_eeprom_in(struct tb_switch *sw, u8 *val)
return 0; return 0;
} }
/** /*
* tb_eeprom_get_drom_offset - get drom offset within eeprom * tb_eeprom_get_drom_offset - get drom offset within eeprom
*/ */
static int tb_eeprom_get_drom_offset(struct tb_switch *sw, u16 *offset) static int tb_eeprom_get_drom_offset(struct tb_switch *sw, u16 *offset)
...@@ -162,7 +162,7 @@ static int tb_eeprom_get_drom_offset(struct tb_switch *sw, u16 *offset) ...@@ -162,7 +162,7 @@ static int tb_eeprom_get_drom_offset(struct tb_switch *sw, u16 *offset)
return 0; return 0;
} }
/** /*
* tb_eeprom_read_n - read count bytes from offset into val * tb_eeprom_read_n - read count bytes from offset into val
*/ */
static int tb_eeprom_read_n(struct tb_switch *sw, u16 offset, u8 *val, static int tb_eeprom_read_n(struct tb_switch *sw, u16 offset, u8 *val,
...@@ -374,7 +374,7 @@ static int tb_drom_parse_entry_port(struct tb_switch *sw, ...@@ -374,7 +374,7 @@ static int tb_drom_parse_entry_port(struct tb_switch *sw,
return 0; return 0;
} }
/** /*
* tb_drom_parse_entries - parse the linked list of drom entries * tb_drom_parse_entries - parse the linked list of drom entries
* *
* Drom must have been copied to sw->drom. * Drom must have been copied to sw->drom.
...@@ -410,7 +410,7 @@ static int tb_drom_parse_entries(struct tb_switch *sw) ...@@ -410,7 +410,7 @@ static int tb_drom_parse_entries(struct tb_switch *sw)
return 0; return 0;
} }
/** /*
* tb_drom_copy_efi - copy drom supplied by EFI to sw->drom if present * tb_drom_copy_efi - copy drom supplied by EFI to sw->drom if present
*/ */
static int tb_drom_copy_efi(struct tb_switch *sw, u16 *size) static int tb_drom_copy_efi(struct tb_switch *sw, u16 *size)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment