• Michael Widenius's avatar
    Fixed errors and compiler warnings found by buildbot · 5333dafa
    Michael Widenius authored
    Solaris fixes:
    - Fixed that wait_timeout_func and wait_timeout tests works on solaris
    - We have to compile without NO_ALARM on Solaris as Solaris doesn't support timeouts on sockets with setsockopt(.. SO_RCVTIMEO).
    - Fixed that compile-solaris-amd64-debug works (before that we got a wrong ELF class: ELFCLASS64 on linkage)
    - Added missing sync_with_master
    Other bug fixes:
    - Free memory for rpl_global_gtid_binlog_state before exit() to avoid 'accessing uninitalized mutex' error.
    
    
    
    BUILD/FINISH.sh:
      Fixed issues on Solaris with ksh
    BUILD/compile-solaris-amd64-debug:
      Added missing -m64 flag
    configure.cmake:
      We have to compile without NO_ALARM on Solaris as Solaris doesn't support timeouts on sockets with setsockopt(.. SO_RCVTIMEO)
    mysql-test/suite/rpl/t/rpl_gtid_mdev4473.test:
      - Added missing sync_with_master (fix by knielsen)
    sql-common/client.c:
      Added () to get rid of compiler warning
    sql/item_strfunc.cc:
      Fixed compiler warning
    sql/log.cc:
      Free memory for static variable rpl_global_gtid_binlog_state before exit()
      - If we are compiling with safemalloc, we would try to call sf_free() for some members after sf_terminate() was called, which would result of trying to access the uninitalized mutex 'sf_mutex'
    sql/multi_range_read.cc:
      Fixed compiler warnings of converting double to ulong.
    sql/opt_range.cc:
      Fixed compiler warnings of converting double to ulong or uint
      - Better to have all variables that can be number of rows as 'ha_rows'
    sql/rpl_gtid.cc:
      Added rpl_binlog_state::free() to be able to free memory for static objects before exit()
    sql/rpl_gtid.h:
      Added rpl_binlog_state::free() to be able to free memory for static objects before exit()
    sql/set_var.cc:
      Fixed compiler warning
    sql/sql_join_cache.cc:
      Fixed compiler warnings of converting double to uint
    sql/sql_show.cc:
      Added cast to get rid of compiler warning
    sql/sql_statistics.cc:
      Remove code that didn't do anything.
      (store_record() with record[0] is a no-op)
    storage/xtradb/os/os0file.c:
      Added  __attribute__ ((unused))
    support-files/compiler_warnings.supp:
      Ignore warnings from atomic_add_64_nv
      (was not able to fix this with a cast as the macro is a bit different between systems)
    vio/viosocket.c:
      Added more DBUG_PRINT
    5333dafa
os0file.c 138 KB