• unknown's avatar
    Fixes while reviewing new code · ab54e167
    unknown authored
    Added option --count to mysqlshow (to show number of rows)
    Fixed possible core dump in information schema
    
    
    client/client_priv.h:
      --count for mysqlshow
    client/mysqlshow.c:
      Added option --count to be used when the user want's number of rows per table in the output
      (We shouldn't use count(*) as default as this can be a slow operation)
    mysys/my_thr_init.c:
      Correct comment
    sql/ha_berkeley.cc:
      Remove not used variable
    sql/ha_berkeley.h:
      Remove not used variable
    sql/ha_innodb.cc:
      Remove not used function
    sql/ha_ndbcluster.cc:
      false -> FALSE
      true -> TRUE
    sql/handler.cc:
      Added and fixed comments
      Remove 'strange' code to remove compiler warnings (better to do things like this with attribute)
    sql/item.cc:
      false -> FALSE
    sql/item_cmpfunc.cc:
      Fixed indentation
    sql/item_cmpfunc.h:
      marked BETWEEN as a bool function
    sql/item_func.cc:
      Simple optimzation
    sql/key.cc:
      Removed wrong code
    sql/log.cc:
      Check result from open_index_file()
    sql/mysql_priv.h:
      Simplyfy some test of netware
    sql/mysqld.cc:
      Fixed indentation
      Check result form open_index_file()
      Simplify code with IF_NETWARE()
    sql/opt_range.cc:
      false -> FALSE
      true -> TRUE
      Fixed indentation
    sql/opt_sum.cc:
      Fixed comments
    sql/sp_head.cc:
      Simple optimzation
      Move variable declarations to begining of blocks
    sql/sql_acl.cc:
      Fix long lines
      Rename xx -> column
      Move declaration to beginning of block
    sql/sql_parse.cc:
      Removed comment
    sql/sql_select.cc:
      Indentation fixes
    sql/sql_show.cc:
      Fixed reference outside of array (possible core dump)
    sql/sql_table.cc:
      Simplify code
      Combine common code
    sql/sql_test.cc:
      false -> FALSE
    sql/sql_trigger.cc:
      false -> false
      true -> TRUE
    sql/sql_yacc.yy:
      Simpler test
    sql/unireg.cc:
      Added comment
    ab54e167
opt_sum.cc 24.5 KB