• unknown's avatar
    BUG#9626 Several serious errors reported by Valgrind in latest 5.0 bk tree · 43ebae40
    unknown authored
     - Fix several valgrind warnings.
    
    
    ndb/include/kernel/AttributeList.hpp:
      Include ndb_limits.h
    ndb/include/ndbapi/Ndb.hpp:
      Add new function internalize_table_name
      Proper formatting
    ndb/include/util/SimpleProperties.hpp:
      Add function "add" for adding strings/data to word buffers without reading after the string/data 
      Fix comment for UtilBufferWriter
    ndb/src/common/util/SimpleProperties.cpp:
      Add function "add" for adding strings/data to word buffers without reading after the string/data
    ndb/src/ndbapi/DictCache.cpp:
      Add DBUG printouts to all functions in GlobalDictCache
      Change ndbout_c to DBUG_PRINT
      Add function GlobalDictCache::printCache
    ndb/src/ndbapi/DictCache.hpp:
      Add function GlobalDictCache::printCache
    ndb/src/ndbapi/Ndb.cpp:
      Change DEBUG_TRACE to DBUG_PRINT, DBUG_ENTER
      Use new function internalize_table_name, and create internal tabname on stack
    ndb/src/ndbapi/NdbDictionary.cpp:
      Add DBUG_ENTER calls
    ndb/src/ndbapi/NdbDictionaryImpl.cpp:
      Pass BaseString as reference when passing internal table name to internal functions.
      Remove check for exceeding MAX_SECTION_SIZE.
      Remove pekkas fix that saves internalName in save_me variable, not needed when tablename is stack variable.
      NdbDictInterface::gettable(int tableid, ...) - Not used
    ndb/src/ndbapi/NdbDictionaryImpl.hpp:
      Remove include of ndb_limits.h
      Use BaseString& for internal functions
      Remove m_namebuf, not needed, uses m_buffer
      Formatting
      NdbDictInterface::getTable(int tableId, ...) - Not used
    ndb/src/ndbapi/NdbImpl.hpp:
      Remove buffer for m_internalname, placed on stack of caller.
      Moved impl of internalize_table_name and internalize_index_anme to Ndb::internalize_table_name and Ndb::internalize_index_name
    ndb/src/ndbapi/NdbLinHash.hpp:
      Save also the terminating null character in chain->str to get nicer printouts.
    ndb/src/ndbapi/NdbTransaction.cpp:
      Remove hardcoded buffer sizes.
      Remove include of ndb_limits.h
    sql/ha_ndbcluster.cc:
      Fix "typo", use file_name var since that is the current files name,
    43ebae40
NdbDictionaryImpl.cpp 82.4 KB