• Sergei Golubchik's avatar
    fix memory leaks and other problems found by safemalloc · 49501b4c
    Sergei Golubchik authored
    client/mysql_upgrade.c:
      missing DBUG_RETURN
    client/mysqladmin.cc:
      client plugin memory wasn't freed
    client/mysqlcheck.c:
      client plugin memory, defaults, a result set, a command-line option value were not freed.
      missing DBUG_RETURN.
    client/mysqldump.c:
      client plugin memory wasn't freed
    client/mysqlslap.c:
      client plugin memory wasn't freed
    client/mysqltest.cc:
      hopeless. cannot be fixed.
    mysql-test/valgrind.supp:
      Bug#56666 is now fixed.
    mysys/array.c:
      really, don't allocate if the caller didn't ask to.
    mysys/my_init.c:
      safemalloc checks must be done at the very end
    mysys/my_thr_init.c:
      not needed anymore
    sql-common/client.c:
      memory leak
    sql/log.cc:
      log_file was not closed, memory leak.
    sql/mysqld.cc:
      fix bug#56666 (causing many P_S related memory leaks).
      close_active_mi() not called for --bootstrap, memory leak.
    sql/sql_lex.cc:
      redo Lex->mi handling
    sql/sql_lex.h:
      redo Lex->mi handling
    sql/sql_plugin.cc:
      plugins having PLUGIN_VAR_MEMALLOC string variables have this variables allocated in every THD.
      The memory was freed in ~THD but only if plugin was still active. If plugin was unloaded the
      variable was not found and the memory was lost. By loading and unloading plugins an arbitrary
      amount of memory can be lost.
    sql/sql_repl.cc:
      redo Lex->mi handling
    sql/sql_yacc.yy:
      completely wrong handling of Lex->mi - run-time memory leak, by repeating the statement
      arbitrary amount of memory can be lost.
      
      Lex->mi.repl_ignore_server_ids_opt was allocated when parsing CHANGE MASTER,
      and freed after executing the statement. if parser failed on syntax (or another)
      error the statement was never executed. Lex->mi was simply bzero-ed for the next
      CHANGE MASTER  statement.
    sql/table.cc:
      didn't compile
    storage/perfschema/pfs_lock.h:
      Bug#56666 is fixed
    49501b4c
my_thr_init.c 13 KB