• unknown's avatar
    Review fixes of new pushed code · 64206b18
    unknown authored
    - Fixed tests
    - Optimized new code
    - Fixed some unlikely core dumps
    - Better bug fixes for:
      - #14397 - OPTIMIZE TABLE with an open HANDLER causes a crash
      - #14850 (ERROR 1062 when a quering a view using a Group By on a column that can be null
    
    
    mysql-test/r/create.result:
      Update results after removing wrong warnings for CREATE ... SELECT
      New tests
    mysql-test/r/handler.result:
      Drop used tables
    mysql-test/r/kill.result:
      Make test portable
    mysql-test/r/mysqlshow.result:
      Drop tables used by previous test
    mysql-test/r/trigger.result:
      Reuse old procedure name
    mysql-test/r/view.result:
      Extra tests
    mysql-test/t/create.test:
      New tests to test fix of removing wrong warnings for CREATE ... SELECT
    mysql-test/t/disabled.def:
      Enable 'kill' test (should now be portable)
    mysql-test/t/handler.test:
      Drop used tables
    mysql-test/t/kill.test:
      Make test portable even if kill doesn't work at once
    mysql-test/t/mysqlshow.test:
      Drop tables used by previous test
    mysql-test/t/trigger.test:
      Reuse old procedure name
    mysql-test/t/view.test:
      Extra tests
    sql/field.cc:
      Removed compiler warning
    sql/ha_federated.cc:
      my_snprintf -> strmake()
      (Simple optimization)
    sql/ha_ndbcluster.cc:
      Indentation cleanups and trival optimization
    sql/item.cc:
      Moved save_org_in_field() to item.cc to make it easier to test
      Remove setting of null_value as this is not needed
    sql/item.h:
      Moved save_org_in_field() to item.cc to make it easier to test
    sql/log_event.cc:
      Remove inline of slave_load_file_stem()
      Added 'extension' parameter to slave_load_file_stem() to get smaller code
      Removed not critical (or needed) DBUG_ASSERT()'s
      Cleaned up usage of slave_load_file_stem() to not depend on constant string lengths
      Indentation fixes
    sql/opt_range.cc:
      Moved code from declaration to function body
      (To make it more readable)
    sql/parse_file.cc:
      Fixed DBUG_PRINT
    sql/sp.cc:
      Simple cleanups
      - Removed not needed {} level
      - Ensure saved variables starts with old_
    sql/sp_head.cc:
      Indentation fixes
      Remove core dump when using --debug when m_next_cached_sp == 0
      Fixed compiler warnings
      Trivial optimizations
    sql/sp_head.h:
      Changed argument to set_definer() to const
      Added THD argument to recursion_level_error() to avoid call to current_thd
    sql/sql_acl.cc:
      Removed not needed test (first_not_own_table is the guard)
    sql/sql_base.cc:
      Removed extra empty line
    sql/sql_handler.cc:
      Don't test table version in mysql_ha_read() as this is already tested in lock_tables()
      Moved call to insert_fields to be after lock_table() to guard aganst reopen of tables
      (Better fix for Bug#14397 - OPTIMIZE TABLE with an open HANDLER causes a crash)
    sql/sql_insert.cc:
      Mark fields that are set in CREATE ... SELECT as used
      (Removed wrong warnings about field not having a default value)
    sql/sql_parse.cc:
      Removed not needed test of 'tables' (first_not_own_table is the guard)
      Simplify code
    sql/sql_select.cc:
      Use group->field to check if value is null instead of item called by 'save_org_in_field'
      This is a better bug fix for #14850 (ERROR 1062 when a quering a view using a Group By on a column that can be null)
    sql/sql_trigger.cc:
      Move sql_modes_parameters outside of function
      Indentation fixes
      Fixed compiler warning
      Ensure that thd->lex->query_tables_own_last is set properly before calling check_table_access()
      (This allows us to remove the extra test in check_grant() and check_table_access())
    64206b18
sql_trigger.cc 37 KB