• unknown's avatar
    Fix Valgrind errors seen in buildbot. · c558b3e0
    unknown authored
    Fix mysql-test-run.pl to not terminate early when warnings in error logs are detected during
    server shutdown. Instead, give a nice summary report at the end of the failures.
    
    Fix code to make 100% sure no failures will go undetected.
    
    Revert earlier wrong change.
    
    Fix race with port allocation semaphore file permissions.
    
    Adjust testsuite to copy with new PBXT engine now in the tree. The PBXT engine causes an
    extra table to appear in the INFORMATION_SCHEMA. This causes different output for a few
    test cases.
    
    dbug/dbug.c:
      If DbugParse() is called multiple times, the stack->keywords for the
      top stack frame could be overwritten without being freed, causing a
      memory leak reported by Valgrind.
    include/my_global.h:
      Add useful macro for different values when Valgrind (HAVE_purify) and not.
    mysql-test/extra/rpl_tests/rpl_auto_increment.test:
      Omit pbxt variables from show variables output.
    mysql-test/include/have_pbxt.inc:
      Add facility to disable test if PBXT engine is not available.
    mysql-test/lib/mtr_report.pm:
      Give a nice summary report at the end of tests of any warnings seen in logs during
      server shutdowns.
    mysql-test/lib/mtr_unique.pm:
      Move chmod 777 to greatly reduce the risk of leaving the port semaphore file unaccessible
      bu other users.
    mysql-test/mysql-test-run.pl:
      Don't abort in case of warnings detected, instead give a nice summary report.
      
      Fix code to make 100% sure no failures will go undetected.
      
      Revert earlier wrong change when master disconnects early.
    mysql-test/r/information_schema.result:
      Omit PBXT INFORMATION_SCHEMA table from output.
      Move part of test to information_schema_all_engines.
    mysql-test/r/information_schema_all_engines.result:
      New file for information_schema tests that depend on which engines are available.
    mysql-test/r/information_schema_db.result:
      Move part of test to information_schema_all_engines.
    mysql-test/r/innodb-autoinc.result:
      Omit pbxt variables from show variables output.
    mysql-test/r/mysqlshow.result:
      Move part of test to information_schema_all_engines.
    mysql-test/suite/rpl/r/rpl_auto_increment.result:
      Omit pbxt variables from show variables output.
    mysql-test/t/information_schema.test:
      Omit PBXT INFORMATION_SCHEMA table from output.
      Move part of test to information_schema_all_engines.
    mysql-test/t/information_schema_all_engines.test:
      New file for information_schema tests that depend on which engines are available.
    mysql-test/t/information_schema_db.test:
      Move part of test to information_schema_all_engines.
    mysql-test/t/innodb-autoinc.test:
      Omit pbxt variables from show variables output.
    mysql-test/t/mysqlshow.test:
      Move part of test to information_schema_all_engines.
    mysql-test/valgrind.supp:
      Add variant suppression (different system library versions).
      Add suppression for problem with inet_ntoa().
    sql/mysqld.cc:
      Fix missing DBUG_RETURN.
      Fix uninitialised thd->connect_utime, likely introduced by pool_of_threads.
    sql/set_var.cc:
      Fix one-byte buffer overflow in several places.
      Fix unsafe use of String::c_ptr() of stack-allocated String buffer.
    sql/sql_select.cc:
      Silence valgrind warning due to GCC bug.
    sql/sql_string.h:
      Document potential problem with String::c_ptr() and String() constructor with caller-supplied buffer.
    storage/archive/azio.c:
      Silence Valgrind false warning for libz.
    c558b3e0
information_schema_all_engines.test 2.98 KB